BPF List
 help / color / mirror / Atom feed
From: David Vernet <void@manifault.com>
To: Hao Luo <haoluo@google.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
	andrii@kernel.org, john.fastabend@gmail.com,
	martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
	kpsingh@kernel.org, sdf@google.com, jolsa@kernel.org,
	tj@kernel.org, joannelkoong@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] bpf: Add user-space-publisher ringbuffer map type
Date: Tue, 16 Aug 2022 16:39:59 -0500	[thread overview]
Message-ID: <YvwOr11K4VjNsNzJ@maniforge.DHCP.thefacebook.com> (raw)
In-Reply-To: <CA+khW7gXXEtRg-m5NY16PG1hCMJb2-Bnfrp7rkedAz8JHC5HWA@mail.gmail.com>

On Tue, Aug 16, 2022 at 10:01:38AM -0700, Hao Luo wrote:
> On Tue, Aug 16, 2022 at 8:10 AM David Vernet <void@manifault.com> wrote:
> >
> > On Mon, Aug 15, 2022 at 02:13:13PM -0700, Hao Luo wrote:
> > > >
> > > > Iters allow userspace to kick the kernel, but IMO they're meant to enable
> > > > data extraction from the kernel, and dumping kernel data into user-space.
> > >
> > > Not necessarily extracting data and dumping data. It could be used to
> > > do operations on a set of objects, the operation could be
> > > notification. Iterating and notifying are orthogonal IMHO.
> > >
> > > > What I'm proposing is a more generalizable way of driving logic in the
> > > > kernel from user-space.
> > > > Does that make sense? Looking forward to hearing your thoughts.
> > >
> > > Yes, sort of. I see the difference between iter and the proposed
> > > interface. But I am not clear about the motivation of a new APis for
> > > kicking callbacks from userspace. I guess maybe it will become clear,
> > > when you publish a concerte RFC of that interface and integrates with
> > > your userspace publisher.
> >
> > Fair enough -- let me remove this from the cover letter in future
> > versions of the patch-set. To your point, there's probably little to be
> > gained in debating the merits of adding such APIs until there's a
> > concrete use-case.
> >
> 
> Yep, sounds good. I don't mean to debate :) I would like to help. If
> we could build on top of existing infra and make improvements, IMHO it
> would be easier to maintain. Anyway, I'm looking forward to your
> proposed APIs.

Don't worry, I did not take it that you were debating. I very much
appreciate your thoughts and help. If and when I send out that RFC
patchset, I'll be sure to cc you (if not reach out beforehand as well to
discuss).

      reply	other threads:[~2022-08-16 21:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 15:52 [PATCH 0/5] bpf: Add user-space-publisher ringbuffer map type David Vernet
2022-08-08 18:57 ` Hao Luo
2022-08-10  1:15   ` David Vernet
2022-08-15 21:13     ` Hao Luo
2022-08-16 15:09       ` David Vernet
2022-08-16 17:01         ` Hao Luo
2022-08-16 21:39           ` David Vernet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YvwOr11K4VjNsNzJ@maniforge.DHCP.thefacebook.com \
    --to=void@manifault.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=haoluo@google.com \
    --cc=joannelkoong@gmail.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=sdf@google.com \
    --cc=song@kernel.org \
    --cc=tj@kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox