From: Jiri Olsa <olsajiri@gmail.com>
To: Yonghong Song <yhs@fb.com>
Cc: bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
kernel-team@fb.com
Subject: Re: [PATCH bpf-next] selftests/bpf: Add selftest deny_namespace to s390x deny list
Date: Thu, 6 Oct 2022 09:27:58 +0200 [thread overview]
Message-ID: <Yz6Dfi2uo0lxyvzO@krava> (raw)
In-Reply-To: <20221006053429.3549165-1-yhs@fb.com>
On Wed, Oct 05, 2022 at 10:34:29PM -0700, Yonghong Song wrote:
> BPF CI reported that selftest deny_namespace failed with s390x.
>
> test_unpriv_userns_create_no_bpf:PASS:no-bpf unpriv new user ns 0 nsec
> test_deny_namespace:PASS:skel load 0 nsec
> libbpf: prog 'test_userns_create': failed to attach: ERROR: strerror_r(-524)=22
> libbpf: prog 'test_userns_create': failed to auto-attach: -524
> test_deny_namespace:FAIL:attach unexpected error: -524 (errno 524)
> #57/1 deny_namespace/unpriv_userns_create_no_bpf:FAIL
> #57 deny_namespace:FAIL
>
> BPF program test_userns_create is a BPF LSM type program which is
> based on trampoline and s390x does not support s390x. Let add the
> test to x390x deny list to avoid this failure in BPF CI.
>
> Signed-off-by: Yonghong Song <yhs@fb.com>
lgtm
Acked-by: Jiri Olsa <jolsa@kernel.org>
jirka
> ---
> tools/testing/selftests/bpf/DENYLIST.s390x | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/bpf/DENYLIST.s390x b/tools/testing/selftests/bpf/DENYLIST.s390x
> index 17e074eb42b8..0fb03b8047d5 100644
> --- a/tools/testing/selftests/bpf/DENYLIST.s390x
> +++ b/tools/testing/selftests/bpf/DENYLIST.s390x
> @@ -75,3 +75,4 @@ user_ringbuf # failed to find kernel BTF type ID of
> lookup_key # JIT does not support calling kernel function (kfunc)
> verify_pkcs7_sig # JIT does not support calling kernel function (kfunc)
> kfunc_dynptr_param # JIT does not support calling kernel function (kfunc)
> +deny_namespace # failed to attach: ERROR: strerror_r(-524)=22 (trampoline)
> --
> 2.30.2
>
next prev parent reply other threads:[~2022-10-06 7:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 5:34 [PATCH bpf-next] selftests/bpf: Add selftest deny_namespace to s390x deny list Yonghong Song
2022-10-06 7:27 ` Jiri Olsa [this message]
2022-10-06 15:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz6Dfi2uo0lxyvzO@krava \
--to=olsajiri@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox