Re: [PATCH bpf-next 0/4] likely/unlikely for bpf_helpers

[Anton Protopopov <aspsk@isovalent.com>]

On 25/03/31 01:12PM, Andrii Nakryiko wrote:
> On Mon, Mar 31, 2025 at 1:08 AM Anton Protopopov
> <a.s.protopopov@gmail.com> wrote:
> >
> > Andrii suggested to send this piece with small fixes
> > separately from the insn set rfc.
> >
> > The first patch fixes a comment in <linux/bpf.h>, and the latter
> > three patches add likely/unlikely macros to <bph/bpf_helpers.h>.
> > The reason there are three patches and not one is to separate
> > libbpf changes such that userspace libbpf can be updated more
> > easily, and the order is such that each commit can be built.
> >
> > Anton Protopopov (4):
> >   bpf: fix a comment describing bpf_attr
> >   selftests/bpf: add guard macros around likely/unlikely
> >   libbpf: add likely/unlikely macros
> >   selftests/bpf: remove likely/unlikely definitions
> 
> let's just collapse the last 3 patches into one? libbpf sync process
> will be totally fine with that.

Thanks, I've squashed them in v2.

> pw-bot: cr
> 
> >
> >  include/uapi/linux/bpf.h                          | 2 +-
> >  tools/include/uapi/linux/bpf.h                    | 2 +-
> >  tools/lib/bpf/bpf_helpers.h                       | 8 ++++++++
> >  tools/testing/selftests/bpf/bpf_arena_spin_lock.h | 3 ---
> >  tools/testing/selftests/bpf/progs/iters.c         | 2 --
> >  5 files changed, 10 insertions(+), 7 deletions(-)
> >
> > --
> > 2.34.1
> >