From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9948533E1; Thu, 26 Dec 2024 21:19:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735247975; cv=none; b=QXQADb+LMee58Nxmy9NJSdO/qrqXdyVaXbI+4Zl53WK/kGHKbHln4D98veN0uMcp+KtFsVNedPFFeh/mE74DeFTTvwvWdYnaQIrx0mv/4hTNPc79Q06diHDXrnIZBHeE0qRQsfSjkVCRjjmLRtVunmSwtmNQ3xzpWL2j8r2QPxI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735247975; c=relaxed/simple; bh=oXezXdLl02Y1+/BmoYocjDwKBbLKHaxLDcFwjZf4zNo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MMYCTP/cDhGVnYXDot08HgfH/z4zFWuU8s3uNCgqNHe6qtlfEIONv2CKHeSJkbCDE7xQv2GmJE9jiEbnoH6K2nRebcqdmRgc84aF1L/SrWimgTteofjxoyy+xP6DErE/VBKxyyLxSpH7A7bsyvO2ZNC7iQo0sbIDWF86EBkEwCk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=icmTzly/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="icmTzly/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D100BC4CED1; Thu, 26 Dec 2024 21:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1735247975; bh=oXezXdLl02Y1+/BmoYocjDwKBbLKHaxLDcFwjZf4zNo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=icmTzly/uM9WxmeMG5TwyFhtRfKcDqVJXA7K3SLGdT3R0JQeAQOe4bevxMd2IR+ix i8bMmydunJimhp69xMgxUvgxKFmYjXs2pMysZ3wstfB5i+x03s2+nJQ6oTbwlL+AUd Ve+T8PxNxisksULxZSjZy5UMfIkDJkeny1Xvsg6+MFidxm+iOtx0f4hOmAR6XsFRCA 7veiATgJaDz9pUEeijJimmbM5uhPjJHdHlRSMa6591jpbDYk4Qi/tl/Ke6Oj28Mw3J N9ARCaktgu570peEVoF0gCgVa38Ud0a+7O5yen4EfiEQDyKRSsiA3ZxmdS1JCPYk9N tWIx8hWvS7uIA== Date: Thu, 26 Dec 2024 18:19:32 -0300 From: Arnaldo Carvalho de Melo To: Alan Maguire Cc: Eduard Zingerman , dwarves@vger.kernel.org, arnaldo.melo@gmail.com, bpf@vger.kernel.org, kernel-team@fb.com, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, yonghong.song@linux.dev Subject: Re: [PATCH dwarves v1 2/2] tests: verify that pfunct prints btf_decl_tags read from BTF Message-ID: References: <20241211021227.2341735-1-eddyz87@gmail.com> <20241211021227.2341735-2-eddyz87@gmail.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Dec 26, 2024 at 06:14:12PM -0300, Arnaldo Carvalho de Melo wrote: > On Thu, Dec 26, 2024 at 06:11:57PM -0300, Arnaldo Carvalho de Melo wrote: > > On Thu, Dec 12, 2024 at 07:50:57PM +0000, Alan Maguire wrote: > > > On 11/12/2024 02:12, Eduard Zingerman wrote: > > > > When using BTF as a source, pfunct should now be able to print > > > > btf_decl_tags for programs like below: > > > > > > > > #define __tag(x) __attribute__((btf_decl_tag(#x))) > > > > __tag(a) __tag(b) void foo(void) {} > > > > > > > > This situation arises after recent kernel changes, where tags 'kfunc' > > > > and 'bpf_fastcall' are added to some functions. To avoid dependency on > > > > a recent kernel version test this by compiling a small C program using > > > > clang with --target=bpf, which would instruct clang to generate .BTF > > > > section. > > > > > > > > Signed-off-by: Eduard Zingerman > > > > > > nit: the test is great but it would be good to print out a description > > > even in non-verbose mode; when I run it via ./tests I see > > > > > > 5: Ok > > > > > > could we just echo the comment below, i.e. > > > > > > 5 : Check that pfunct can print btf_decl_tags read from BTF: Ok > > > > > > ? > > To clarify, I'm doing as Alan suggests and adding that message when the > test succeeds. Running just this test: root@number:/home/acme/git/pahole# tests/pfunct-btf-decl-tags.sh Check that pfunct can print btf_decl_tags read from BTF: Ok root@number:/home/acme/git/pahole# > > > Reviewed-by: Alan Maguire > > > Tested-by: Alan Maguire > > > > Thanks, applied. > > > > - Arnaldo > >