From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E668C256D for ; Thu, 30 Jan 2025 00:03:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738195391; cv=none; b=sOi0MkpxZW0QAcxc6BAaSJrd1uBkTX6DgHioQFZ/ToOIvpN46AwNQPgs4df52sD8FYtzUGI8BgajdVfCpM8rvvGukMckCccSFxNsIBT6ebgq48sFjkB2KnU3asdwXqhNJ7KGp7QtsE9iywwPy6OKs3KAh2q6gJsZchwWpzwSDLU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738195391; c=relaxed/simple; bh=Sj+Xftkj+qlU0BJkHbd30+qFOwtKIfmhoQgIOQHpgUI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XapVuG3GbwLAR3bqwjFgjZXiKVBdbXU6Gikm6DcIzKMdUd0kaQ9AMkgMM3kOZpQpx5yq/3En9lblrpjGCYii975VYMKcQpPxHwRcoAdVMojJQa3T3JS4AU1bS6gURCsoTnqZn1OeHAINH3JhUqKWAnzr8LIcgcMB7If+u/eFgG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=YPvEluGN; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YPvEluGN" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2163affd184so31275ad.1 for ; Wed, 29 Jan 2025 16:03:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738195388; x=1738800188; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=s/sWxNAPnxEZbenKOf7N+j5g5zHNpFBMXZn1jjqHCpE=; b=YPvEluGNgyFZPEEjR70NUgr6F8+rXep+nPfIJUmbXr8s0VwoEKbQIBg5PvdfGN2Plp dMxEu7Pasf3JHqG0bTQi21iiNH/4klD0turhBl4E34BpBlCuxOvacqA37hfF/eTZDQFR 8llJS176B7SKQd1j7kwKR57hUNB50wTzVX/nLIhPMQWJr5BiEO3fWujd64fovw4UiAq2 IQUKZVwe/BovKE2WvBaS7UoZcsbzXunY+GPjas4e2IWIAdBAyUymLU4ZnW20ZvIeh2lY 6rUqolYMD36OllrH1vj44NnnPHmPrturxiLPV8vJBrMS8loA0vsso5JvO/HaX18SlAWn mz9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738195388; x=1738800188; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s/sWxNAPnxEZbenKOf7N+j5g5zHNpFBMXZn1jjqHCpE=; b=o5MWDGdFZYTQbaIFppSz5n3/Rn9M37d1SAN2J9VwIIT2UNcKwac9XsrLgpiFU6j6Nk fRaBR4sSRanm3hJkVBD0pMziTG1cqHd8JGZPONHeGstsO0G/9q26pJgaG8wdxcRWAu1Z bpUJCPZbQP41ltOJrtyqj//0tuDK7QaG6yKr8PTjx4H1xYpYHbUZbEi6YLTS3MPvR/EY ei0r5/ohZ2ze4MR7WYvurEhv8IVz/vMeo5hoer3WfMBMEsKQjps2CUpN4hVhKYTNv553 w0TJiSp9lCQTpS2bE79bdce23mlj3+empJG2qUGZ7pm/GCtt9nB3Cy3KdPCnN+MY3FjI waFg== X-Gm-Message-State: AOJu0Yzz01Zm4O/Irx96ICupY+EyMcuFG9oOzKiUmxADtxKU5rCVTDe5 /k6zOeb1IrqIAqcT6tLmv3H2vGIWiotgP7wNEvuHsR81ECKy935qXha9qryMGQ== X-Gm-Gg: ASbGncsUAJb3YXWXnp1I2/Bo3AvO/msvLv4IjmMWszr2QtnRtR1Pmzt1j43JZIktoGe Z6SAnJoj3O8WWDL8peWwdAG1IvShosdeeCCAJiBmV9l9KRpQtdLEktjBvW0SQ2vWBuuqB/bR8MC ik7wzjcoxcf2CMlA+GI84wskdJrqyuSabfMf10uh4fxDKK+ihNYZjnEP1/WIKdCiuZEsD2Dtzvb J3qdRtFHBNbx9WAhjC9a2fkztUlVArPEX1vfxRcxBM6xLA4+FRxKQawjX+qSnJwedcr8IPh6Ew1 njcyOYVF+AEYXaTwN0nWwhITGPlmfAhxKZ7bQJdaaj+O9WQ+plA= X-Google-Smtp-Source: AGHT+IE/F0VzN3ET6T5NQ93cCyrPvlKbgWQX6l9EQyxxToYjZ5gVa1o2Iroc9xQVHfCVOmJeGyKC/g== X-Received: by 2002:a17:902:7447:b0:21a:5501:9d3 with SMTP id d9443c01a7336-21de36ce371mr481865ad.21.1738195387986; Wed, 29 Jan 2025 16:03:07 -0800 (PST) Received: from google.com (55.131.16.34.bc.googleusercontent.com. [34.16.131.55]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f83bccc8a5sm2405786a91.17.2025.01.29.16.03.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2025 16:03:07 -0800 (PST) Date: Thu, 30 Jan 2025 00:03:03 +0000 From: Peilin Ye To: Eduard Zingerman Cc: bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bpf@ietf.org, Xu Kuohai , David Vernet , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Jonathan Corbet , "Paul E. McKenney" , Puranjay Mohan , Catalin Marinas , Will Deacon , Quentin Monnet , Mykola Lysenko , Shuah Khan , Josh Don , Barret Rhoden , Neel Natu , Benjamin Segall , linux-kernel@vger.kernel.org, Ihor Solodrai Subject: Re: [PATCH bpf-next v1 7/8] selftests/bpf: Add selftests for load-acquire and store-release instructions Message-ID: References: <3f2de7c6e5d2def7bdfb091347c1dacea0915974.1737763916.git.yepeilin@google.com> <131a817f7f2749e78e527a251ca7971588cf62f8.camel@gmail.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <131a817f7f2749e78e527a251ca7971588cf62f8.camel@gmail.com> On Tue, Jan 28, 2025 at 05:06:03PM -0800, Eduard Zingerman wrote: > On Sat, 2025-01-25 at 02:19 +0000, Peilin Ye wrote: > > All new tests depend on the pre-defined __BPF_FEATURE_LOAD_ACQ_STORE_REL > > feature macro, which implies -mcpu>=v4. > > This restriction would mean that tests are skipped on BPF CI, as it > currently runs using llvm 17 and 18. Instead, I suggest using some > macro hiding an inline assembly as below: > > asm volatile (".8byte %[insn];" > : > : [insn]"i"(*(long *)&(BPF_RAW_INSN(...))) > : /* correct clobbers here */); > > See the usage of the __imm_insn() macro in the test suite. I see, I'll do this in v2. > Also, "BPF_ATOMIC loads from R%d %s is not allowed\n" and > "BPF_ATOMIC stores into R%d %s is not allowed\n" > situations are not tested. Thanks! > > --- a/tools/testing/selftests/bpf/prog_tests/atomics.c > > +++ b/tools/testing/selftests/bpf/prog_tests/atomics.c > > @@ -162,6 +162,56 @@ static void test_xchg(struct atomics_lskel *skel) > > ASSERT_EQ(skel->bss->xchg32_result, 1, "xchg32_result"); > > } > > Nit: Given the tests in verifier_load_acquire.c and verifier_store_release.c > that use __retval annotation, are these tests really necessary? > (assuming that verifier_store_release.c tests are modified to read > stored location into r0 before exit). > > > +static void test_load_acquire(struct atomics_lskel *skel) Ah, right. I'll drop them and modify verifier_store_release.c accordingly. > > --- a/tools/testing/selftests/bpf/progs/arena_atomics.c > > +++ b/tools/testing/selftests/bpf/progs/arena_atomics.c > [...] > > > +SEC("raw_tp/sys_enter") > > +int load_acquire(const void *ctx) > > +{ > > + if (pid != (bpf_get_current_pid_tgid() >> 32)) > > + return 0; > > Nit: This check is not needed, since bpf_prog_test_run_opts() is used > to run the tests. Got it! Thanks, Peilin Ye