From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55830205ABC for ; Wed, 12 Feb 2025 13:30:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739367031; cv=none; b=fGhr3B6jmxxrEcIask1BEz2e3ZOHwm0oZq0rIxNF4LR0tTnC2bDp6NqtyKS5cXcyBLajrBKB3bJZ81z641bUv3NyRVlKOnNksqlFwWNz2OSyEbxspz6vpDV9Pk6mkyKGCJSqK4eeQ9z35O6W/wnVn5wiolwKf2h0GQnH7rUn5zM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739367031; c=relaxed/simple; bh=cppRDKTH5X7+PhdoGd1D1mSrJYsVfO2+TtgwU+r5HiM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dtsgRoP8V0v9pLIb2uJMBN9gUgLjRwkoVSR6pzGBTieBY3HXtKfhx+vOaPRUQ6ovPR0t++ajr4gHK6srxS0lHxT5I51xgs3GxOkYSkcE8RHT02bKzbv/psFpggjm/x0O1IUbPHpxXhaet7KrqLc1FDPkTMfYJ09t5Cr0riw9r2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=bI9eezHu; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="bI9eezHu" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-220c4159f87so6767845ad.0 for ; Wed, 12 Feb 2025 05:30:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1739367029; x=1739971829; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=bq7SdSXo+JhFwWwHQa7/twUcE0+PVputBf+G7gcfT+Q=; b=bI9eezHuZ1YRlXLL26JDblxdtNGRFf09dr3q1mu7Lynz47ayzTiLJjJhKXhTy/9k+B 0D4ITt6y8zAWEjZ/FVrGl4QY3nS95UcnG7ba0x7HqugSdeMpRZFhqv9YE4C5N+qjDbQe LoFfdGwBDdNyt6mq/GpTEhAdKGpI+BpwLuogA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739367029; x=1739971829; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bq7SdSXo+JhFwWwHQa7/twUcE0+PVputBf+G7gcfT+Q=; b=IPoQf9gVVX/WFJKAxc35DS62iSoSq3RvCCifZ62txPAokX8+OxTyeAdFczYmg3AnYt webU0C3RR67amJCls6u1Are1HWCjlPrzhPpP9viDNZP8S1/9BZRjbYRGD62eVfvnNCkB xvk1ht7IjyYJ+4LNS+5BoC5FicuBQqmGcZKYIb6ZCE4h6G/pv8pLEl8Qr1CS438R7L10 T/3ByQeAgrznG81DZ3rJ+MgdsmVxsO28ZKx9QtuoKvkhBqL+ROpb/Sdx7hg7MpzeoSQ/ OG4CWhiLFa4mzOC/oOR4y27FZF5+UlR+MyIioc7T7yKQoVxsex5MPT0tCrkVaH13YgN3 nBlA== X-Forwarded-Encrypted: i=1; AJvYcCWQYl6b3JUF53N5u2NdKFbCbdAvOchnaYuYO2dV4rolHgZZ2ueByo0UWaVROOa61FLC9/U=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6Lo4Leht5WY277gyGLSFIOc4nm1eFHG4JTLK1ENOnuJqy4lYC IpjWzVtccl59ZOcjURm6CHm6/K+3ctuQ4LpNAiGz81yVK+73uqBZp4gwaxzAsNM= X-Gm-Gg: ASbGncu3wCbFM64HZ0NrJhvyCfis1XxLBT1flwb11/WSb52doyFiK98+gsSyEc23bg9 vQfBIxiErbyFyjF+6y46ZPpsw2EU9zRW9Pl51A+3jXYKzrKNGmXl7YZlay+Uqao75tqgHleYIa+ agisAeprepnskitMJpD9gO/osrqIErV+HJOCBNF/TYlw3dFepUQQRYmKHl/qzgW2lBg9IDqSXUk xt7nZIxyewDTybfiRyy8dbu99Or5HVtVm3yvchyues0hRulq0fLqvinTG73HD7WVFy9uQSVZ7HQ IMYnH5D1ChkAcmALbbNbICovj9YaceIMDS4THoUA67pkrUsvaphIHizA5A== X-Google-Smtp-Source: AGHT+IE/UeUsPjMO1gpNMj4yctOpDIpP/4atL2aTr+WokGGBV4mZ/QiJjiwEjLs7hX6m+RhsVtK1Fg== X-Received: by 2002:a17:90a:fc46:b0:2fa:1a23:c01d with SMTP id 98e67ed59e1d1-2fbf5c10491mr4674200a91.21.1739367029580; Wed, 12 Feb 2025 05:30:29 -0800 (PST) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fbf98b4c52sm1448513a91.4.2025.02.12.05.30.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 05:30:29 -0800 (PST) Date: Wed, 12 Feb 2025 05:30:26 -0800 From: Joe Damato To: Jakub Kicinski Cc: Stanislav Fomichev , Paolo Abeni , netdev@vger.kernel.org, horms@kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , open list , "open list:KERNEL SELFTEST FRAMEWORK" , "open list:XDP (eXpress Data Path):Keyword:(?:b|_)xdp(?:b|_)" Subject: Re: [PATCH net-next v6 3/3] selftests: drv-net: Test queue xsk attribute Message-ID: Mail-Followup-To: Joe Damato , Jakub Kicinski , Stanislav Fomichev , Paolo Abeni , netdev@vger.kernel.org, horms@kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , open list , "open list:KERNEL SELFTEST FRAMEWORK" , "open list:XDP (eXpress Data Path):Keyword:(?:b|_)xdp(?:b|_)" References: <20250210193903.16235-1-jdamato@fastly.com> <20250210193903.16235-4-jdamato@fastly.com> <13afab27-2066-4912-b8f6-15ee4846e802@redhat.com> <20250211183706.5b53ee5e@kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250211183706.5b53ee5e@kernel.org> On Tue, Feb 11, 2025 at 06:37:06PM -0800, Jakub Kicinski wrote: > On Tue, 11 Feb 2025 15:10:52 -0800 Stanislav Fomichev wrote: > > > I can't comment on NIPA because I have no idea how it works. Maybe > > > there is a kernel with some options enabled and other kernels with > > > various options disabled? > > > > Sorry, should've been more clear. My suggestion is to add > > CONFIG_XDP_SOCKETS to tools/testing/selftests/drivers/net/config > > to make your new testcase run in a proper environment with XSKs enabled. > > +1 this we need for sure OK will do. > > > I wonder if that's a separate issue though? > > > > > > In other words: maybe writing the test as I've mentioned above so it > > > works regardless of whether CONFIG_XDP_SOCKETS is set or not is a > > > good idea just on its own? > > > > > > I'm just not sure if there's some other pattern I should be > > > following other than what I proposed above. I'm hesitant to re-spin > > > until I get feedback on the proposed approach. > > > > I'd keep your test as is (fail hard if XSK is not there), but > > let's see if Paolo/Jakub have any other suggestions. > > No strong preference. Stan is right that validating the environment > is definitely a non-goal for the upstream tests. But if you already > added and tested the checks Joe you can keep them, up to you. OK. I guess I'll just leave them? They are as described earlier in the thread.