From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75CBB22258E for ; Mon, 10 Mar 2025 08:05:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741593933; cv=none; b=XnEuDWr5R7xa38/D+wJZVOCknJ504K+QmNAV5FrTIwjAVgJrV9SJf5KFlzMAFFhX1QeyOLPxYUTIcsMKKx+kD8Z+Zjz6N/8ww/kpG1VlrNGFgP84bPpOBgzwMDxJcbE/fD2tnX1Iw164kLyXhElv1smIiBGcmH+rrDheG/1GjYQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741593933; c=relaxed/simple; bh=3zWnGu58N16ImW59wQBusJJKObQVZ1jczDB54CFg87Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R7j9vZderH6idO0UE110hGvA3eJyXyTYkmcDQ3TVgMQeN9TPXWNbOg5KaHSCjdtsI7lfNEMIcDati8sdzn/xKAHg40WrADl/B07gybLXxKXBZ65UfOqognFdjzxJg+dQz3GpkQH1bYnsAqAzdAUGEPSeQCsmzfnAPQHK0LeX070= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=isovalent.com; spf=pass smtp.mailfrom=isovalent.com; dkim=pass (2048-bit key) header.d=isovalent.com header.i=@isovalent.com header.b=BqgMezPu; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=isovalent.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=isovalent.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=isovalent.com header.i=@isovalent.com header.b="BqgMezPu" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5e5e0caa151so5319425a12.0 for ; Mon, 10 Mar 2025 01:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent.com; s=google; t=1741593930; x=1742198730; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9/46n50lkXxXG2Ap+gYI/XvZtdQWDWRE7Pv0p9E/S7A=; b=BqgMezPu4DBwnxdrN72L/a2FDiNJoqB1r3qrmz0ArTnSWkeHKi/zZrfIl7uIWDGlnb s7+vV/+27ws9cLAEAuVr0o6QGsPc/mfPMAtppU17yce2gvUNJ0jlLBo6omHzqgEZGCZq R880fOHEfPGu7lXq8IfcahiV7lDbtI/KHVP9HXgGxtw2JNkKVkc08SCxNxVjxhM6CHgZ S9Q0ToTH+hSYICYeLWs8nQQkyNMrcmAdXMh3PkBxQ9T+VrS2b4vz1a/SiEsEYdkuw5HY gmfpr09IWvthDFL4Vl9M3QJOiyW6rSPS3GGwYMgkk3dS81GwrCsW08A/jajdCKoWc8Xr M0hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741593930; x=1742198730; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9/46n50lkXxXG2Ap+gYI/XvZtdQWDWRE7Pv0p9E/S7A=; b=SZ4SomhCSrv2U+W3infD5vBOzENL5zo2indd6awzSC0zmF1U1StIdQGVAtd/VFEZot UBJHYZPi35ldjnixMUzJ7SuycSjHRGVDGYBuR33WGz/EF3uOjXRs31LNBmsX3NXeA/Pz DHwKYXgNEWMf7fs7xrG08gC/wxLNqOPcsJTl/348OEN6cmGhAjhrOEIQoME/C3gjv1h0 w0nPdlDNdR/E9Sg0/9NvT1AXsItu/JG+Y/lGwtmQACjOqtG2x2wXc/LXTiJ22yEXgrwL MgBHJgOK42VgTWvv/xnycULTgMHuj0OB2tqlZQO+nhcs98ysd/wcwuTms5Pi9KfGt5V7 WBZw== X-Forwarded-Encrypted: i=1; AJvYcCW7cxAPsj71HOc8dmhesWnYMvg1PS7W/u0Bk1oyl1iDZ6qX87rNg1ueF4tclVoTM3gv8+Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5zRUC+lqIUP88lAhIVupqb/S2lrCalgd/Pk7N9ntSeAQOiHuH khkJRTcUtZ9fVlU+12q7dVmTJMpB/2tYl/ZKrWmSFMbexTyYawj7OJ0C5tqQkKQ= X-Gm-Gg: ASbGncu7Tr0KAVloqlEKIMejbHUOIk6E/I82Km4dV9J0Z0rc0WPuQdbOYSUFEVLz/DP 7q6DAIWf1Oh9vp8iSZ4zovjNbLb1k1SJfC+/nLHxPJEaRS4iW/4bYyka0UDCoGXCLa38qtve3a+ t7ENVAq3tv5MkOUXkMT1MCY0sC/gfxxv5qQd1xa+V+qoCBeq2rEsfBH8H12zKYIDRANuDJNufs1 lHzWHB2eusBg/7aTmU53sIAlzOIRAeaoauMs3vVxdKG7uZKxZwR1wrDkVe+WsKbYZvteQZSsdh1 vWU0VEYVug8Fy1P1nV0P7eSIjvsMY0sdIouXoYGn2BZNEuUE X-Google-Smtp-Source: AGHT+IFyE1+ZQDfcpYaXDj6cU2hjRv5YTsTRSeNjT+LusaidpLpAMwAvHbC7htyCKPAPDOKqhc1SBg== X-Received: by 2002:a05:6402:35d1:b0:5e6:6407:3b27 with SMTP id 4fb4d7f45d1cf-5e664073f4amr5039593a12.31.1741593929576; Mon, 10 Mar 2025 01:05:29 -0700 (PDT) Received: from mail.gmail.com ([2a04:ee41:4:b2de:1ac0:4dff:fe0f:3782]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e5c733fa47sm6471074a12.6.2025.03.10.01.05.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 01:05:28 -0700 (PDT) Date: Mon, 10 Mar 2025 08:09:36 +0000 From: Anton Protopopov To: Chen Ni Cc: andrii@kernel.org, eddyz87@gmail.com, mykolal@fb.com, ast@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, shuah@kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/bpf: Convert comma to semicolon Message-ID: References: <20250310032045.651068-1-nichen@iscas.ac.cn> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250310032045.651068-1-nichen@iscas.ac.cn> On 25/03/10 11:20AM, Chen Ni wrote: > Replace comma between expressions with semicolons. > > Using a ',' in place of a ';' can have unintended side effects. > Although that is not the case here, it is seems best to use ';' > unless ',' is intended. This is a typo, of course. Thanks! > Found by inspection. > No functional change intended. > Compile tested only. > > Signed-off-by: Chen Ni Acked-by: Anton Protopopov > --- > tools/testing/selftests/bpf/prog_tests/fd_array.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/bpf/prog_tests/fd_array.c b/tools/testing/selftests/bpf/prog_tests/fd_array.c > index a1d52e73fb16..9add890c2d37 100644 > --- a/tools/testing/selftests/bpf/prog_tests/fd_array.c > +++ b/tools/testing/selftests/bpf/prog_tests/fd_array.c > @@ -83,8 +83,8 @@ static inline int bpf_prog_get_map_ids(int prog_fd, __u32 *nr_map_ids, __u32 *ma > int err; > > memset(&info, 0, len); > - info.nr_map_ids = *nr_map_ids, > - info.map_ids = ptr_to_u64(map_ids), > + info.nr_map_ids = *nr_map_ids; > + info.map_ids = ptr_to_u64(map_ids); > > err = bpf_prog_get_info_by_fd(prog_fd, &info, &len); > if (!ASSERT_OK(err, "bpf_prog_get_info_by_fd")) > -- > 2.25.1 >