From: Stanislav Fomichev <sdf@google.com>
To: Hengqi Chen <hengqi.chen@gmail.com>
Cc: bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next] selftests/bpf: Don't assume page size is 4096
Date: Mon, 27 Mar 2023 09:37:01 -0700 [thread overview]
Message-ID: <ZCHGLTMeT7089yBu@google.com> (raw)
In-Reply-To: <20230326095341.816023-1-hengqi.chen@gmail.com>
On 03/26, Hengqi Chen wrote:
> The verifier test creates BPF ringbuf maps using hard-coded
> 4096 as max_entries. Some tests will fail if the page size
> of the running kernel is not 4096. Use getpagesize() instead.
> Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
Can you share which platform that is? The fix seems ok, but
I'm assuming that we have many more places where 4k is hardcoded :-)
> ---
> tools/testing/selftests/bpf/test_verifier.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/tools/testing/selftests/bpf/test_verifier.c
> b/tools/testing/selftests/bpf/test_verifier.c
> index 5b90eef09ade..e4657c5bc3f1 100644
> --- a/tools/testing/selftests/bpf/test_verifier.c
> +++ b/tools/testing/selftests/bpf/test_verifier.c
> @@ -1079,7 +1079,7 @@ static void do_test_fixup(struct bpf_test *test,
> enum bpf_prog_type prog_type,
> }
> if (*fixup_map_ringbuf) {
> map_fds[20] = create_map(BPF_MAP_TYPE_RINGBUF, 0,
> - 0, 4096);
> + 0, getpagesize());
> do {
> prog[*fixup_map_ringbuf].imm = map_fds[20];
> fixup_map_ringbuf++;
> --
> 2.31.1
next prev parent reply other threads:[~2023-03-27 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 9:53 [PATCH bpf-next] selftests/bpf: Don't assume page size is 4096 Hengqi Chen
2023-03-27 16:37 ` Stanislav Fomichev [this message]
2023-03-27 18:41 ` Andrii Nakryiko
2023-03-27 18:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCHGLTMeT7089yBu@google.com \
--to=sdf@google.com \
--cc=bpf@vger.kernel.org \
--cc=hengqi.chen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox