From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A91BC6FD18 for ; Fri, 31 Mar 2023 12:21:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232358AbjCaMVs (ORCPT ); Fri, 31 Mar 2023 08:21:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232369AbjCaMV0 (ORCPT ); Fri, 31 Mar 2023 08:21:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E77520D89; Fri, 31 Mar 2023 05:20:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 99D42B82EF2; Fri, 31 Mar 2023 12:20:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B503C433EF; Fri, 31 Mar 2023 12:20:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680265244; bh=TfbE6wzLk2TKNH81FTvCD5+wH6CX9qCYuzTsOvwGjAQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gmWnEDLc2B3+vtE8YUR/PfNvCHDO6mCkYG9aZQWNxw+B5IRKfqv/Tv3lWe4KlM5O8 iBpZ1I35jWqE2J7X6yRPUv9OFr7G5720RZw2jvlrlF12edK2dd8bPbdJsi2UOB6CKc Ho42C9664h/qpPEl+JDRPlvtiuo7P/v6vgvQTlCrJFW7lSMVWv8FomO70N97R35ewn 6g/v2aVHpTX7/40xYCncc/qdCdqqEvoeaLAWkGqpD+xgPSL2YXD/GseRR8GPSN9NdS Yi/Qcz699Pgp3/fjEr/4ZCqj+OfLQkuz2qBCqJHGRKZy3FB7WqEJICDjbrY/pR8ZXP wnqY+zPrT8VAA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 2BDC94052D; Fri, 31 Mar 2023 09:20:42 -0300 (-03) Date: Fri, 31 Mar 2023 09:20:42 -0300 From: Arnaldo Carvalho de Melo To: Eduard Zingerman Cc: dwarves@vger.kernel.org, arnaldo.melo@gmail.com, bpf@vger.kernel.org, kernel-team@fb.com, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, yhs@fb.com Subject: Re: [PATCH dwarves] fprintf: Fix `*` not being printed for pointers with btf_type_tag Message-ID: References: <20230330212700.697124-1-eddyz87@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Em Fri, Mar 31, 2023 at 09:14:39AM -0300, Arnaldo Carvalho de Melo escreveu: > > This part I didn't understand, do you see any possibility of a > > DW_TAG_LLVM_annotation pointing to another DW_TAG_LLVM_annotation? > > I _think_ its a noop, so will test your patch as-is, thanks! Tested, now we're left with normalizing base type names generated by clang and gcc, things like: --- /tmp/gcc 2023-03-31 09:16:34.100006650 -0300 +++ /tmp/clang 2023-03-31 09:16:26.211789489 -0300 @@ -96,8 +96,8 @@ /* XXX 4 bytes hole, try to pack */ - long unsigned int state; /* 216 8 */ - long unsigned int state2; /* 224 8 */ + unsigned long state; /* 216 8 */ + unsigned long state2; /* 224 8 */ struct Qdisc * next_sched; /* 232 8 */ struct sk_buff_head skb_bad_txq; /* 240 24 */ @@ -112,7 +112,7 @@ /* XXX 40 bytes hole, try to pack */ /* --- cacheline 6 boundary (384 bytes) --- */ - long int privdata[]; /* 384 0 */ + long privdata[]; /* 384 0 */ /* size: 384, cachelines: 6, members: 28 */ /* sum members: 260, holes: 4, sum holes: 124 */ @@ -145,19 +145,19 @@ /* XXX 4 bytes hole, try to pack */ struct netdev_queue * (*select_queue)(struct Qdisc *, struct tcmsg *); /* 8 8 */ - int (*graft)(struct Qdisc *, long unsigned int, struct Qdisc *, struct Qdisc * *, struct netlink_ext_ack *); /* 16 8 */ + int (*graft)(struct Qdisc *, unsigned long, struct Qdisc *, struct Qdisc * *, struct netlink_ext_ack *); /* 16 8 */ - struct Qdisc * (*leaf)(struct Qdisc *, long unsigned int); /* 24 8 */ + struct Qdisc * (*leaf)(struct Qdisc *, unsigned long); /* 24 8 */ - void (*qlen_notify)(struct Qdisc *, long unsigned int); /* 32 8 */ + void (*qlen_notify)(struct Qdisc *, unsigned long); /* 32 8 */ - long unsigned int (*find)(struct Qdisc *, u32); /* 40 8 */ + unsigned long (*find)(struct Qdisc *, u32); /* 40 8 */ - int (*change)(struct Qdisc *, u32, u32, struct nlattr * *, long unsigned int *, struct netlink_ext_ack *); /* 48 8 */ + int (*change)(struct Qdisc *, u32, u32, struct nlattr * *, unsigned long *, struct netlink_ext_ack *); /* 48 8 */ - int (*delete)(struct Qdisc *, long unsigned int, struct netlink_ext_ack *); /* 56 8 */ + int (*delete)(struct Qdisc *, unsigned long, struct netlink_ext_ack *); /* 56 8 */ /* --- cacheline 1 boundary (64 bytes) --- */ void (*walk)(struct Qdisc *, struct qdisc_walker *); /* 64 8 */ - struct tcf_block * (*tcf_block)(struct Qdisc *, long unsigned int, struct netlink_ext_ack *); /* 72 8 */ + struct tcf_block * (*tcf_block)(struct Qdisc *, unsigned long, struct netlink_ext_ack *); /* 72 8 */ - long unsigned int (*bind_tcf)(struct Qdisc *, long unsigned int, u32); /* 80 8 */ + unsigned long (*bind_tcf)(struct Qdisc *, unsigned long, u32); /* 80 8 */ - void (*unbind_tcf)(struct Qdisc *, long unsigned int); /* 88 8 */ + void (*unbind_tcf)(struct Qdisc *, unsigned long); /* 88 8 */ - int (*dump)(struct Qdisc *, long unsigned int, struct sk_buff *, struct tcmsg *); /* 96 8 */ + int (*dump)(struct Qdisc *, unsigned long, struct sk_buff *, struct tcmsg *); /* 96 8 */ - int (*dump_stats)(struct Qdisc *, long unsigned int, struct gnet_dump *); /* 104 8 */ + int (*dump_stats)(struct Qdisc *, unsigned long, struct gnet_dump *); /* 104 8 */ /* size: 112, cachelines: 2, members: 14 */ /* sum members: 108, holes: 1, sum holes: 4 */ @@ -227,21 +227,21 @@ This was affected somehow by these LLVM_annotation patches, I'll try to handle this later. - Arnaldo