Re: [PATCH bpf V4 1/5] xdp: rss hash types representation

Jesper Dangaard Brouer
2023-03-31T19:13:29Z

Hopefully addressed in V5.

I obviously need to change function signature for all driver xmo_rx_hash
calls in patch 1/5 to make this compile. I kept the RSS type
implementations for each driver as separate patches as this is more
reasonable to review and handle.

On 31/03/2023 20.23, kernel test robot wrote:
>
[...]
> All errors (new ones prefixed by >>):
>
>>> drivers/net/veth.c:1685:43: error: initialization of 'int (*)(const struct xdp_md *, u32 *, enum xdp_rss_hash_type *)' {aka 'int (*)(const struct xdp_md *, unsigned int *, enum xdp_rss_hash_type *)'} from incompatible pointer type 'int (*)(const struct xdp_md *, u32 *)' {aka 'int (*)(const struct xdp_md *, unsigned int *)'} [-Werror=incompatible-pointer-types]
> 1685 | .xmo_rx_hash = veth_xdp_rx_hash,
> | ^~~~~~~~~~~~~~~~
> drivers/net/veth.c:1685:43: note: (near initialization for 'veth_xdp_metadata_ops.xmo_rx_hash')
> cc1: some warnings being treated as errors