From: Stanislav Fomichev <sdf@google.com>
To: Florent Revest <revest@chromium.org>
Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
kpsingh@kernel.org, mykolal@fb.com, martin.lau@linux.dev,
song@kernel.org, xukuohai@huaweicloud.com, mark.rutland@arm.com
Subject: Re: [PATCH bpf-next] selftests/bpf: Update the aarch64 tests deny list
Date: Thu, 27 Apr 2023 11:56:53 -0700 [thread overview]
Message-ID: <ZErFdVXHhEdJ/m3G@google.com> (raw)
In-Reply-To: <CABRcYm+O-_GGhnAmJW6_=9vKeKSvzVLcxBRq3Pfjb3W0_HNjhw@mail.gmail.com>
On 04/27, Florent Revest wrote:
> On Thu, Apr 27, 2023 at 4:32 PM Florent Revest <revest@chromium.org> wrote:
> >
> > This patch updates the list of BPF selftests which are known to fail so
> > the BPF CI can validate the tests which pass now.
>
> Note: I tested this denylist a few months back by sending a manual PR
> to https://github.com/kernel-patches/bpf.
> At the time, it worked
> https://github.com/kernel-patches/bpf/actions/runs/4106542133/jobs/7085514761
> (even though there seemed to be a known flake in the gcc variant but
> unrelated to the new arch support)
>
> Every time I wanted to have the CI run on my PRs, I had to annoy Manu
> by email (I wouldn't have the rights to trigger the CI by myself
> otherwise). So I haven't tested this *actual* patch rebased on the
> current CI before sending it to the list. (e.g. the
> module_fentry_shadow test has been added since then and I just assumed
> it would pass in CI like the rest)
>
> My understanding is that this patch should soon be picked up by the
> testing bot and we can use that CI run to check that everything works
> as intended. Let's wait for a CI green light before merging this! :)
> If there are errors I'll send a v2
Looks green now:
Acked-by: Stanislav Fomichev <sdf@google.com>
https://github.com/kernel-patches/bpf/actions/runs/4822595792/jobs/8590732278
next prev parent reply other threads:[~2023-04-27 18:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 14:32 [PATCH bpf-next] selftests/bpf: Update the aarch64 tests deny list Florent Revest
2023-04-27 14:52 ` Florent Revest
2023-04-27 18:56 ` Stanislav Fomichev [this message]
2023-04-27 20:10 ` Daniel Borkmann
2023-04-27 20:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZErFdVXHhEdJ/m3G@google.com \
--to=sdf@google.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=revest@chromium.org \
--cc=song@kernel.org \
--cc=xukuohai@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox