From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA47A8BED for ; Tue, 13 Jun 2023 08:29:59 +0000 (UTC) Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABA57184 for ; Tue, 13 Jun 2023 01:29:57 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-3f7e7fc9fe6so52712805e9.3 for ; Tue, 13 Jun 2023 01:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent.com; s=google; t=1686644996; x=1689236996; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fJz3+17+rI7c/r9Lxv1o3gM9l7EUudwPFAZ2efkW9cM=; b=QtW2Ic+jqj4l0V4rUR3g5XwyEe5HAeSBmgBIeCA9Ahj+oPxHvnoLzvMLrdI0W/PdQN NwQTFeVR+CSpq0rd/5K1de/PZ+FysmEXscm5FEMlKUUjbd/CnE23w70QNKdB8nNMRWqF 7iBzg3F8LKamO3rVyJlQGU6+gjTRiNf7mAbKa7hVqJpcoAjV9CnS/btZlLBqmlU0SC1U JRHK6RES+ADnMIcHld/rOi8iUGX/+pibfDpN6UTLVEBnJ10WZdrdqHJoK9IrrrDMST3g 4ooqSpiMqi75GZgOy5Aiu+MSKIXLQR0kgWeu/BLkYMdsbW+eB7Qmvp93LHMahbMfDgaK Dheg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686644996; x=1689236996; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fJz3+17+rI7c/r9Lxv1o3gM9l7EUudwPFAZ2efkW9cM=; b=dLG+0X8fBx+A0wrwTSf919hYf1VG821QAXU6HieUKDYnbbO6hzQFMyjcKOwWVVVPx5 fQ7xmAd8YZXb9i3dnntVQLfSbCpfcuROtaU3mFRbUBt/3O8JP2JngBvXhpm6/sONTrh2 NpWWPmBhi/ZgRVOLWZvDG9ouXnk5vmtGnfCRKIS/d1y+y56ILa9yBkLZmRct8KkmePTi Ho1xiIhlAknrSU8jewKE9dnMzDZI7WAwjDyShdoYp7rKiVzUx0Kqc+rTNcTPzx9HV0UP T/u5CES/uGfB5UcQQYZP5LA138GDBcMF+eFQ9l86v1YrkW2FWiUHX1IJ3Ms32xZkK/Uy kXfA== X-Gm-Message-State: AC+VfDwW7560zzt5+xCzFsK3ZrQIAy/Tw0eVXL4iEIbBtmIH62JfJvq/ yJOMDV4GZA0x8JJgwsxvCVVhZQ== X-Google-Smtp-Source: ACHHUZ6VKL3vVviuMXqByKDjVuBWHuEoYjd4AUXr52K2TFKp398Trwaduu/AdesUxduSSatDHxYwsQ== X-Received: by 2002:a7b:cb8f:0:b0:3f7:26f8:4cd0 with SMTP id m15-20020a7bcb8f000000b003f726f84cd0mr8651529wmi.16.1686644996018; Tue, 13 Jun 2023 01:29:56 -0700 (PDT) Received: from zh-lab-node-5 ([2a02:168:f656:0:1ac0:4dff:fe0f:3782]) by smtp.gmail.com with ESMTPSA id n26-20020a1c721a000000b003f78fd2cf5esm13645608wmc.40.2023.06.13.01.29.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 01:29:55 -0700 (PDT) Date: Tue, 13 Jun 2023 08:30:23 +0000 From: Anton Protopopov To: Yujie Liu Cc: kernel test robot , bpf@vger.kernel.org, oe-kbuild-all@lists.linux.dev, Joe Stringer , John Fastabend Subject: Re: [PATCH bpf-next 1/2] bpf: add new map ops ->map_pressure Message-ID: References: <20230531110511.64612-2-aspsk@isovalent.com> <202306010837.mGhA199K-lkp@intel.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Tue, Jun 13, 2023 at 04:23:29PM +0800, Yujie Liu wrote: > Hi Anton, > > Sorry for the late reply. > > On Thu, Jun 01, 2023 at 07:50:00AM +0000, Anton Protopopov wrote: > > On Thu, Jun 01, 2023 at 08:44:24AM +0800, kernel test robot wrote: > > > Hi Anton, > > > > > > kernel test robot noticed the following build errors: > > > > > > [...] > > > > > > If you fix the issue, kindly add following tag where applicable > > > | Reported-by: kernel test robot > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202306010837.mGhA199K-lkp@intel.com/ > > > > How does this apply to patches? If I send a v2, should I include these tags > > there? > > If a v2 is sent, these tags should not be included. > > > If this patch gets rejected, is there need to do anything to close the > > robot's ticket? > > No need to close this ticket. > > Thanks for raising above concerns. We have updated the wording in our > reports as below to avoid misinterpretation: > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: ... > | Closes: ... Great, thanks for the explanations! > -- > Best Regards, > Yujie > > > > All errors (new ones prefixed by >>): > > > > > > kernel/bpf/hashtab.c: In function 'htab_map_pressure': > > > >> kernel/bpf/hashtab.c:189:24: error: implicit declaration of function '__percpu_counter_sum'; did you mean 'percpu_counter_sum'? [-Werror=implicit-function-declaration] > > > 189 | return __percpu_counter_sum(&htab->pcount); > > > | ^~~~~~~~~~~~~~~~~~~~ > > > | percpu_counter_sum > > > cc1: some warnings being treated as errors > > > > > > > > > vim +189 kernel/bpf/hashtab.c > > > > > > 183 > > > 184 static u32 htab_map_pressure(const struct bpf_map *map) > > > 185 { > > > 186 struct bpf_htab *htab = container_of(map, struct bpf_htab, map); > > > 187 > > > 188 if (htab->use_percpu_counter) > > > > 189 return __percpu_counter_sum(&htab->pcount); > > > 190 return atomic_read(&htab->count); > > > 191 } > > > 192 > > > > (This bug happens for !SMP case.) > > > > > -- > > > 0-DAY CI Kernel Test Service > > > https://github.com/intel/lkp-tests/wiki > >