From: Stanislav Fomichev <sdf@google.com>
To: Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
martin.lau@kernel.org, kernel-team@meta.com
Subject: Re: [PATCH bpf-next 0/4] Clean up BPF permissions checks
Date: Wed, 14 Jun 2023 15:08:03 -0700 [thread overview]
Message-ID: <ZIo6Q60/OdG6AqhW@google.com> (raw)
In-Reply-To: <20230613223533.3689589-1-andrii@kernel.org>
On 06/13, Andrii Nakryiko wrote:
> This patch set contains a few refactorings to BPF map and BPF program creation
> permissions checks, which were originally part of BPF token patch set ([0]),
> but are logically completely independent and useful in their own right.
>
> [0] https://patchwork.kernel.org/project/netdevbpf/list/?series=755113&state=*
>
> Andrii Nakryiko (4):
> bpf: move unprivileged checks into map_create() and bpf_prog_load()
> bpf: inline map creation logic in map_create() function
> bpf: centralize permissions checks for all BPF map types
> bpf: keep BPF_PROG_LOAD permission checks clear of validations
>
> kernel/bpf/bloom_filter.c | 3 -
> kernel/bpf/bpf_local_storage.c | 3 -
> kernel/bpf/bpf_struct_ops.c | 3 -
> kernel/bpf/cpumap.c | 4 -
> kernel/bpf/devmap.c | 3 -
> kernel/bpf/hashtab.c | 6 -
> kernel/bpf/lpm_trie.c | 3 -
> kernel/bpf/queue_stack_maps.c | 4 -
> kernel/bpf/reuseport_array.c | 3 -
> kernel/bpf/stackmap.c | 3 -
> kernel/bpf/syscall.c | 155 +++++++++++-------
> net/core/sock_map.c | 4 -
> net/xdp/xskmap.c | 4 -
> .../bpf/prog_tests/unpriv_bpf_disabled.c | 6 +-
> 14 files changed, 102 insertions(+), 102 deletions(-)
>
> --
> 2.34.1
>
Since I took a look at this as part of the original series, and these
are really non-controversial changes, feel free to use:
Acked-by: Stanislav Fomichev <sdf@google.com>
next prev parent reply other threads:[~2023-06-14 22:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 22:35 [PATCH bpf-next 0/4] Clean up BPF permissions checks Andrii Nakryiko
2023-06-13 22:35 ` [PATCH bpf-next 1/4] bpf: move unprivileged checks into map_create() and bpf_prog_load() Andrii Nakryiko
2023-06-13 22:35 ` [PATCH bpf-next 2/4] bpf: inline map creation logic in map_create() function Andrii Nakryiko
2023-06-13 22:35 ` [PATCH bpf-next 3/4] bpf: centralize permissions checks for all BPF map types Andrii Nakryiko
2023-06-13 22:35 ` [PATCH bpf-next 4/4] bpf: keep BPF_PROG_LOAD permission checks clear of validations Andrii Nakryiko
2023-06-14 22:08 ` Stanislav Fomichev [this message]
2023-06-19 12:10 ` [PATCH bpf-next 0/4] Clean up BPF permissions checks patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIo6Q60/OdG6AqhW@google.com \
--to=sdf@google.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@meta.com \
--cc=martin.lau@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox