From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next v1 2/2] net: core: Sort headers alphabetically
Date: Tue, 12 Sep 2023 20:04:48 +0300 [thread overview]
Message-ID: <ZQCaMHBHp/Ha29ao@smile.fi.intel.com> (raw)
In-Reply-To: <20f57b1309b6df60b08ce71f2d7711fa3d6b6b44.camel@redhat.com>
On Tue, Sep 12, 2023 at 06:53:23PM +0200, Paolo Abeni wrote:
> On Tue, 2023-09-12 at 19:35 +0300, Andy Shevchenko wrote:
> > On Tue, Sep 12, 2023 at 05:20:31PM +0200, Simon Horman wrote:
> > > On Mon, Sep 11, 2023 at 06:45:34PM +0300, Andy Shevchenko wrote:
> > > > It's rather a gigantic list of heards that is very hard to follow.
> > > > Sorting helps to see what's already included and what's not.
> > > > It improves a maintainability in a long term.
> > > >
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > >
> > > Hi Andy,
> > >
> > > At the risk of bike shedding, the sort function of Vim, when operating
> > > with the C locale, gives a slightly different order, as experssed by
> > > this incremental diff.
> > >
> > > I have no objections to your oder, but I'm slightly curious as
> > > to how it came about.
> >
> > !sort which is external command.
> >
> > $ locale -k LC_COLLATE
> > collate-nrules=4
> > collate-rulesets=""
> > collate-symb-hash-sizemb=1303
> > collate-codeset="UTF-8"
>
> I'm unsure this change is worthy. It will make any later fix touching
> the header list more difficult to backport, and I don't see a great
> direct advantage.
As Rasmus put it here
https://lore.kernel.org/lkml/5eca0ab5-84be-2d8f-e0b3-c9fdfa961826@rasmusvillemoes.dk/
In short term you can argue that it's not beneficial, but in long term it's given
less conflicts.
> Please repost the first patch standalone.
Why to repost, what did I miss? It's available via lore, just run
b4 am -slt -P _ 20230911154534.4174265-1-andriy.shevchenko@linux.intel.com
to get it :-)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-12 17:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 15:45 [PATCH net-next v1 1/2] net: core: Use the bitmap API to allocate bitmaps Andy Shevchenko
2023-09-11 15:45 ` [PATCH net-next v1 2/2] net: core: Sort headers alphabetically Andy Shevchenko
2023-09-12 15:20 ` Simon Horman
2023-09-12 16:35 ` Andy Shevchenko
2023-09-12 16:53 ` Paolo Abeni
2023-09-12 17:04 ` Andy Shevchenko [this message]
2023-09-12 17:07 ` Alexei Starovoitov
2023-09-12 17:22 ` Andy Shevchenko
2023-09-12 17:25 ` Paolo Abeni
2023-09-13 11:10 ` Andy Shevchenko
2023-09-12 15:21 ` [PATCH net-next v1 1/2] net: core: Use the bitmap API to allocate bitmaps Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQCaMHBHp/Ha29ao@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox