Re: [PATCH bpf-next 6/8] bpf: Add arch_bpf_trampoline_size()

Jiri Olsa
2023-09-21T17:26:31Z

On Thu, Sep 21, 2023 at 04:25:02PM +0200, Jiri Olsa wrote:
> On Tue, Sep 19, 2023 at 10:31:56PM -0700, Song Liu wrote:
>
> SNIP
>
> > bool bpf_jit_supports_subprog_tailcalls(void)
> > diff --git a/arch/x86/net/bpf_jit_comp.c b/arch/x86/net/bpf_jit_comp.c
> > index 5f7528cac344..eca561621e65 100644
> > --- a/arch/x86/net/bpf_jit_comp.c
> > +++ b/arch/x86/net/bpf_jit_comp.c
> > @@ -2422,10 +2422,10 @@ static int invoke_bpf_mod_ret(const struct btf_func_model *m, u8 **pprog,
> > * add rsp, 8 // skip eth_type_trans's frame
> > * ret // return to its caller
> > */
> > -int arch_prepare_bpf_trampoline(struct bpf_tramp_image *im, void *image, void *image_end,
> > - const struct btf_func_model *m, u32 flags,
> > - struct bpf_tramp_links *tlinks,
> > - void *func_addr)
> > +static int __arch_prepare_bpf_trampoline(struct bpf_tramp_image *im, void *image, void *image_end,
> > + const struct btf_func_model *m, u32 flags,
> > + struct bpf_tramp_links *tlinks,
> > + void *func_addr)
> > {
>
> hum, I dont understand what's the __arch_prepare_bpf_trampoline for,
> could we have just the arch_prepare_bpf_trampoline?

ok, in the next patch ;-)

jirka