From: Shung-Hsi Yu <shung-hsi.yu@suse.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, Mohamed Mahmoud <mmahmoud@redhat.com>
Subject: Re: Hitting verifier backtracking bug on 6.5.5 kernel
Date: Mon, 23 Oct 2023 10:08:31 +0800 [thread overview]
Message-ID: <ZTXVn3EMBELuV-yH@u94a> (raw)
In-Reply-To: <87mswds1c7.fsf@toke.dk>
On Fri, Oct 20, 2023 at 06:30:48PM +0200, Toke Høiland-Jørgensen wrote:
> Toke Høiland-Jørgensen <toke@redhat.com> writes:
> > Shung-Hsi Yu <shung-hsi.yu@suse.com> writes:
> >
> >> Patch based on Andrii's analysis.
> >>
> >> Given that both BPF_END and BPF_NEG always operates on dst_reg itself
> >> and that bt_is_reg_set(bt, dreg) was already checked I believe we can
> >> just return with no futher action.
> >
> > Alright, manually applied this to bpf-next and indeed this enables the
> > netobserv-bpf-agent to load successfully. Care to submit a formal patch?
> > In that case please add my:
> >
> > Tested-by: Toke Høiland-Jørgensen <toke@redhat.com>
> >
> > Thanks!
>
> Friendly ping - are you planning to submit an official patch for this? :)
Yes, I do plan to send an offical one along with selftest as Alexei has
suggested. Once I've got my irrational fear of writing selftests overcame ;)
Should have it out before the end of this week.
Shung-Hsi
> -Toke
next prev parent reply other threads:[~2023-10-23 2:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 20:25 Hitting verifier backtracking bug on 6.5.5 kernel Toke Høiland-Jørgensen
2023-10-13 21:11 ` Andrii Nakryiko
2023-10-16 19:36 ` Toke Høiland-Jørgensen
2023-10-16 20:22 ` Andrii Nakryiko
2023-10-17 11:08 ` Toke Høiland-Jørgensen
2023-10-17 12:16 ` Mohamed Mahmoud
2023-10-17 15:39 ` Shung-Hsi Yu
2023-10-17 15:26 ` Shung-Hsi Yu
2023-10-17 17:22 ` Alexei Starovoitov
2023-10-17 17:24 ` Toke Høiland-Jørgensen
2023-10-20 16:30 ` Toke Høiland-Jørgensen
2023-10-23 2:08 ` Shung-Hsi Yu [this message]
2023-10-23 9:27 ` Toke Høiland-Jørgensen
2023-10-30 14:16 ` Shung-Hsi Yu
2023-10-30 14:44 ` Toke Høiland-Jørgensen
2023-10-17 5:33 ` Hengqi Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTXVn3EMBELuV-yH@u94a \
--to=shung-hsi.yu@suse.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=mmahmoud@redhat.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox