From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E43C61EB28 for ; Fri, 27 Oct 2023 13:25:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P1n5Fznn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35FDDC433C8; Fri, 27 Oct 2023 13:25:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698413114; bh=03RYZfrBUfkXjOlDdjGD9+dpnxu38yIUbIWWZ3ySeKw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P1n5Fznnt7y/H9IBPs563IdgXZnB49rjQLMgLiFJIKRMwtNRu7cY3qq1yF+DXwti6 KpfMvqAz9D2GVn1JrDyuMGFD2AyHxTG4ds+wQsdZQvN30kpngwc1Q1z35Fo5NK1Q+m lXjUBwXQ/zSZ51FwiFCFpV3cdWsKbc42ALmDr0r85qN97X6o3FikBr8YjoEJthuobD xw91Qm+GuaNAVqSY5oTKPZkJbeEJ8dEW8a0aNqkPA0sjmlI+XqUc3e/6VgZ4jFhlia mji3h9wyt81X02oexjaMFO6WAu5PjIubxzEzJL7CB5yeIbHAXFWf4haGuyp5dteCdg 9of/b7U3VATHw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 68E9A4035D; Fri, 27 Oct 2023 10:25:07 -0300 (-03) Date: Fri, 27 Oct 2023 10:25:07 -0300 From: Arnaldo Carvalho de Melo To: Andrii Nakryiko Cc: Eduard Zingerman , Arnaldo Carvalho de Melo , Alan Maguire , Jiri Olsa , ast@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, mykolal@fb.com, bpf@vger.kernel.org Subject: Re: [PATCH v4 dwarves 0/5] pahole, btf_encoder: support --btf_features Message-ID: References: <20231023095726.1179529-1-alan.maguire@oracle.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Em Thu, Oct 26, 2023 at 03:06:15PM -0700, Andrii Nakryiko escreveu: > On Wed, Oct 25, 2023 at 3:28 PM Eduard Zingerman wrote: > > > > On Wed, 2023-10-25 at 15:30 -0300, Arnaldo Carvalho de Melo wrote: > > > Em Wed, Oct 25, 2023 at 03:12:49PM -0300, Arnaldo Carvalho de Melo escreveu: > > > > But I guess the acks/reviews + my tests are enough to merge this as-is, > > > > thanks for your work on this! > > > > > > Ok, its in the 'next' branch so that it can go thru: > > > > > > https://github.com/libbpf/libbpf/actions/workflows/pahole.yml > > > > > > But the previous days are all failures, probably something else is > > > preventing this test from succeeding? Andrii? > > > > It looks like the latest run succeeded, while a number of previous > > runs got locked up for some reason. All using the same kernel > > checkpoint commit. I know how to setup local github runner, > > so I can try to replicate this by forking the repo, > > redirecting CI to my machine and executing it several times. > > Will do this over the weekend, need to work on some verifier > > bugs first. > > > > BPF selftests are extremely unreliable under slow Github runners, > unfortunately. Kernel either crashes or locks up very frequently. It > has nothing to do with libbpf and we don't seem to see this in BPF CI > due to having much faster runners there. > > I'm not sure what to do about this apart from trying to identify a > selftest that causes lock up (extremely time consuming endeavor) or > just wait till libbpf CI will be privileged enough to gain its own > fast AWS-based worker :) > > But it seems like the last scheduled run succeeded, I think you are good. I'm not sure it got the btf_features patch, I'll try to change the cmake files to print the HEAD so that when looking at the output in the github actions I can be sure that it is using what needs to be tested. - Arnaldo