BPF List
 help / color / mirror / Atom feed
From: "Sudip Mukherjee (Codethink)" <sudipm.mukherjee@gmail.com>
To: Chuyi Zhou <zhouchuyi@bytedance.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	regressions@lists.linux.dev,
	Yonghong Song <yonghong.song@linux.dev>,
	bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: mainline build failure due to 9c66dc94b62a ("bpf: Introduce css_task open-coded iterator kfuncs")
Date: Thu, 2 Nov 2023 08:50:08 +0000	[thread overview]
Message-ID: <ZUNiwMLBsL52X9wa@debian> (raw)

Hi All,

The latest mainline kernel branch fails to build mips decstation_64_defconfig,
decstation_defconfig and decstation_r4k_defconfig with the error:

kernel/bpf/task_iter.c: In function 'bpf_iter_css_task_new':
kernel/bpf/task_iter.c:917:14: error: 'CSS_TASK_ITER_PROCS' undeclared (first use in this function)
  917 |         case CSS_TASK_ITER_PROCS | CSS_TASK_ITER_THREADED:
      |              ^~~~~~~~~~~~~~~~~~~
kernel/bpf/task_iter.c:917:14: note: each undeclared identifier is reported only once for each function it appears in
kernel/bpf/task_iter.c:917:36: error: 'CSS_TASK_ITER_THREADED' undeclared (first use in this function)
  917 |         case CSS_TASK_ITER_PROCS | CSS_TASK_ITER_THREADED:
      |                                    ^~~~~~~~~~~~~~~~~~~~~~
kernel/bpf/task_iter.c:925:60: error: invalid application of 'sizeof' to incomplete type 'struct css_task_iter'
  925 |         kit->css_it = bpf_mem_alloc(&bpf_global_ma, sizeof(struct css_task_iter));
      |                                                            ^~~~~~
kernel/bpf/task_iter.c:928:9: error: implicit declaration of function 'css_task_iter_start'; did you mean 'task_seq_start'? [-Werror=implicit-function-declaration]
  928 |         css_task_iter_start(css, flags, kit->css_it);
      |         ^~~~~~~~~~~~~~~~~~~
      |         task_seq_start
kernel/bpf/task_iter.c: In function 'bpf_iter_css_task_next':
kernel/bpf/task_iter.c:938:16: error: implicit declaration of function 'css_task_iter_next'; did you mean 'class_dev_iter_next'? [-Werror=implicit-function-declaration]
  938 |         return css_task_iter_next(kit->css_it);
      |                ^~~~~~~~~~~~~~~~~~
      |                class_dev_iter_next
kernel/bpf/task_iter.c:938:16: warning: returning 'int' from a function with return type 'struct task_struct *' makes pointer from integer without a cast [-Wint-conversion]
  938 |         return css_task_iter_next(kit->css_it);
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/bpf/task_iter.c: In function 'bpf_iter_css_task_destroy':
kernel/bpf/task_iter.c:947:9: error: implicit declaration of function 'css_task_iter_end' [-Werror=implicit-function-declaration]
  947 |         css_task_iter_end(kit->css_it);
      |         ^~~~~~~~~~~~~~~~~

git bisect pointed to 9c66dc94b62a ("bpf: Introduce css_task open-coded iterator kfuncs")

I will be happy to test any patch or provide any extra log if needed.

#regzbot introduced: 9c66dc94b62aef23300f05f63404afb8990920b4

-- 
Regards
Sudip

             reply	other threads:[~2023-11-02  8:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02  8:50 Sudip Mukherjee (Codethink) [this message]
2023-11-02  8:53 ` mainline build failure due to 9c66dc94b62a ("bpf: Introduce css_task open-coded iterator kfuncs") Chuyi Zhou
2023-11-02  9:13   ` Linux regression tracking (Thorsten Leemhuis)
2023-11-02 16:04     ` Sudip Mukherjee
2023-11-02 16:40       ` Linux regression tracking (Thorsten Leemhuis)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZUNiwMLBsL52X9wa@debian \
    --to=sudipm.mukherjee@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=torvalds@linux-foundation.org \
    --cc=yonghong.song@linux.dev \
    --cc=zhouchuyi@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox