From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b="KwWu3Bpt" Received: from a.mx.secunet.com (a.mx.secunet.com [62.96.220.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 320DFFE; Mon, 4 Dec 2023 00:25:50 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id E4AA3204D9; Mon, 4 Dec 2023 09:25:47 +0100 (CET) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hvPwaSxxYUiK; Mon, 4 Dec 2023 09:25:47 +0100 (CET) Received: from mailout2.secunet.com (mailout2.secunet.com [62.96.220.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id 4C40920078; Mon, 4 Dec 2023 09:25:47 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 a.mx.secunet.com 4C40920078 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secunet.com; s=202301; t=1701678347; bh=6LGB45I5byCoMEvvTmFWKfhjgGrm1+u7IAc5pF3fXcc=; h=Date:From:To:CC:Subject:References:In-Reply-To:From; b=KwWu3BptcKE5mMLWl8mHeIi9qJxIyxohZ3pyPiU8GufgBcZRy11AsRCirUPTY3RQ5 VCuwAOdD4D+GLjwzzqx1CbPm/IV7UUyKjO5zDaHy7JJ76KnHdWhkYiJBa1+jQVCd8/ WhCMr8qRJOI7Oe6Z6dM/unK4csL4qMFT2PaB9f4kbIaooD4Ks7XPzx6bo99hCXx/Pv B9U4v3BDF/XeDlHwKkMgRtWDKt0SX0DWReAbIC1e+0lAfqcmxD1TmpeUi6WkrEFUHl D0oGMrMRGiFTY9e/9xvWryQ0LkLVPlrF2/+GQIVr9TUbardkk3RRGkhURoBQiqNKzU 5owz2QNMth0Qg== Received: from cas-essen-02.secunet.de (unknown [10.53.40.202]) by mailout2.secunet.com (Postfix) with ESMTP id 164F580004A; Mon, 4 Dec 2023 09:25:47 +0100 (CET) Received: from mbx-essen-02.secunet.de (10.53.40.198) by cas-essen-02.secunet.de (10.53.40.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 4 Dec 2023 09:25:46 +0100 Received: from gauss2.secunet.de (10.182.7.193) by mbx-essen-02.secunet.de (10.53.40.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 4 Dec 2023 09:25:46 +0100 Received: by gauss2.secunet.de (Postfix, from userid 1000) id 49F6131811E6; Mon, 4 Dec 2023 09:25:46 +0100 (CET) Date: Mon, 4 Dec 2023 09:25:46 +0100 From: Steffen Klassert To: Daniel Xu CC: Alexei Starovoitov , Network Development , LKML , bpf , clang-built-linux , "open list:KERNEL SELFTEST FRAMEWORK" , , Yonghong Song , Eddy Z , , Eyal Birger Subject: Re: [PATCH ipsec-next v3 0/9] Add bpf_xdp_get_xfrm_state() kfunc Message-ID: References: Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: cas-essen-02.secunet.de (10.53.40.202) To mbx-essen-02.secunet.de (10.53.40.198) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 On Fri, Dec 01, 2023 at 05:16:04PM -0700, Daniel Xu wrote: > On Fri, Dec 01, 2023 at 04:10:18PM -0800, Alexei Starovoitov wrote: > > On Fri, Dec 1, 2023 at 12:23 PM Daniel Xu wrote: > > > > > > include/net/xfrm.h | 9 + > > > net/xfrm/Makefile | 1 + > > > net/xfrm/xfrm_policy.c | 2 + > > > net/xfrm/xfrm_state_bpf.c | 128 ++++++++++++++ > > > tools/lib/bpf/bpf_core_read.h | 34 ++++ > > > .../selftests/bpf/prog_tests/test_tunnel.c | 162 +++++++++++++++++- > > > .../selftests/bpf/prog_tests/verifier.c | 2 + > > > tools/testing/selftests/bpf/progs/bpf_misc.h | 1 + > > > .../selftests/bpf/progs/bpf_tracing_net.h | 1 + > > > .../selftests/bpf/progs/test_tunnel_kern.c | 138 ++++++++------- > > > .../bpf/progs/verifier_bitfield_write.c | 100 +++++++++++ > > > tools/testing/selftests/bpf/test_loader.c | 7 + > > > tools/testing/selftests/bpf/test_tunnel.sh | 92 ---------- > > > 13 files changed, 522 insertions(+), 155 deletions(-) > > > > I really think this should go via bpf-next tree. > > The bpf changes are much bigger than ipsec. > > Ack. Ended up picking up a lot of stuff along the way. I'm fine with merging this via the bpf-next tree. Please consider to merge the bpf hepler functions to one file. We have already xfrm_interface_bpf.c and now you introduce xfrm_state_bpf.c. Try to merge this into a single xfrm_bpf.c file.