From: Jiri Olsa <olsajiri@gmail.com>
To: Hou Tao <houtao@huaweicloud.com>
Cc: bpf@vger.kernel.org, Martin KaFai Lau <martin.lau@linux.dev>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>, Song Liu <song@kernel.org>,
Hao Luo <haoluo@google.com>,
Yonghong Song <yonghong.song@linux.dev>,
Daniel Borkmann <daniel@iogearbox.net>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>,
John Fastabend <john.fastabend@gmail.com>,
xingwei lee <xrivendell7@gmail.com>,
houtao1@huawei.com
Subject: Re: [PATCH bpf-next v2 3/4] selftests/bpf: Add test for abnormal cnt during multi-uprobe attachment
Date: Wed, 13 Dec 2023 15:43:10 +0100 [thread overview]
Message-ID: <ZXnC_utPtXeqAIs3@krava> (raw)
In-Reply-To: <20231213112531.3775079-4-houtao@huaweicloud.com>
On Wed, Dec 13, 2023 at 07:25:30PM +0800, Hou Tao wrote:
> From: Hou Tao <houtao1@huawei.com>
>
> If an abnormally huge cnt is used for multi-uprobes attachment, the
> following warning will be reported:
>
> ------------[ cut here ]------------
> WARNING: CPU: 7 PID: 406 at mm/util.c:632 kvmalloc_node+0xd9/0xe0
> Modules linked in: bpf_testmod(O)
> CPU: 7 PID: 406 Comm: test_progs Tainted: G ...... 6.7.0-rc3+ #32
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996) ......
> RIP: 0010:kvmalloc_node+0xd9/0xe0
> ......
> Call Trace:
> <TASK>
> ? __warn+0x89/0x150
> ? kvmalloc_node+0xd9/0xe0
> bpf_uprobe_multi_link_attach+0x14a/0x480
> __sys_bpf+0x14a9/0x2bc0
> do_syscall_64+0x36/0xb0
> entry_SYSCALL_64_after_hwframe+0x6e/0x76
> ......
> </TASK>
> ---[ end trace 0000000000000000 ]---
>
> So add a test to ensure the warning is fixed.
>
> Signed-off-by: Hou Tao <houtao1@huawei.com>
> ---
> .../bpf/prog_tests/uprobe_multi_test.c | 33 ++++++++++++++++++-
> 1 file changed, 32 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c b/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c
> index ece260cf2c0b..0d2a4510e6cf 100644
> --- a/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c
> +++ b/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c
> @@ -234,6 +234,35 @@ static void test_attach_api_syms(void)
> test_attach_api("/proc/self/exe", NULL, &opts);
> }
>
> +static void test_failed_link_api(void)
> +{
> + LIBBPF_OPTS(bpf_link_create_opts, opts);
> + const char *path = "/proc/self/exe";
> + struct uprobe_multi *skel = NULL;
> + unsigned long offset = 0;
> + int link_fd = -1;
> +
> + skel = uprobe_multi__open_and_load();
> + if (!ASSERT_OK_PTR(skel, "uprobe_multi__open_and_load"))
> + goto cleanup;
> +
> + /* abnormal cnt */
> + opts.uprobe_multi.path = path;
> + opts.uprobe_multi.offsets = &offset;
> + opts.uprobe_multi.cnt = INT_MAX;
> + opts.kprobe_multi.flags = 0;
s/k/u/ ^^^ .. or best just remove the line
jirka
> + link_fd = bpf_link_create(bpf_program__fd(skel->progs.uprobe), 0,
> + BPF_TRACE_UPROBE_MULTI, &opts);
> + if (!ASSERT_ERR(link_fd, "link_fd"))
> + goto cleanup;
> + if (!ASSERT_EQ(link_fd, -EINVAL, "invalid cnt"))
> + goto cleanup;
> +cleanup:
> + if (link_fd >= 0)
> + close(link_fd);
> + uprobe_multi__destroy(skel);
> +}
> +
> static void __test_link_api(struct child *child)
> {
> int prog_fd, link1_fd = -1, link2_fd = -1, link3_fd = -1, link4_fd = -1;
> @@ -311,7 +340,7 @@ static void __test_link_api(struct child *child)
> free(offsets);
> }
>
> -void test_link_api(void)
> +static void test_link_api(void)
> {
> struct child *child;
>
> @@ -408,6 +437,8 @@ void test_uprobe_multi_test(void)
> test_attach_api_syms();
> if (test__start_subtest("link_api"))
> test_link_api();
> + if (test__start_subtest("failed_link_api"))
> + test_failed_link_api();
> if (test__start_subtest("bench_uprobe"))
> test_bench_attach_uprobe();
> if (test__start_subtest("bench_usdt"))
> --
> 2.29.2
>
next prev parent reply other threads:[~2023-12-13 14:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 11:25 [PATCH bpf-next v2 0/4] bpf: Fix warnings in kvmalloc_node() Hou Tao
2023-12-13 11:25 ` [PATCH bpf-next v2 1/4] bpf: Limit the number of uprobes when attaching program to multiple uprobes Hou Tao
2023-12-13 11:25 ` [PATCH bpf-next v2 2/4] bpf: Limit the number of kprobes when attaching program to multiple kprobes Hou Tao
2023-12-13 23:32 ` Andrii Nakryiko
2023-12-14 1:00 ` Hou Tao
2023-12-13 11:25 ` [PATCH bpf-next v2 3/4] selftests/bpf: Add test for abnormal cnt during multi-uprobe attachment Hou Tao
2023-12-13 14:43 ` Jiri Olsa [this message]
2023-12-14 1:02 ` Hou Tao
2023-12-13 11:25 ` [PATCH bpf-next v2 4/4] selftests/bpf: Add test for abnormal cnt during multi-kprobe attachment Hou Tao
2023-12-13 23:33 ` Andrii Nakryiko
2023-12-14 1:44 ` Hou Tao
2023-12-14 4:26 ` Andrii Nakryiko
2023-12-13 14:42 ` [PATCH bpf-next v2 0/4] bpf: Fix warnings in kvmalloc_node() Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXnC_utPtXeqAIs3@krava \
--to=olsajiri@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=houtao1@huawei.com \
--cc=houtao@huaweicloud.com \
--cc=john.fastabend@gmail.com \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=xrivendell7@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox