From: Manu Bretelle <chantr4@gmail.com>
To: Quentin Monnet <quentin@isovalent.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
bpf <bpf@vger.kernel.org>, Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH v1 bpf-next 1/9] bpftool: add testing skeleton
Date: Thu, 14 Dec 2023 22:37:07 -0800 [thread overview]
Message-ID: <ZXv0E0+npdrWNEvh@surya> (raw)
In-Reply-To: <4aa42cb9-a03b-403c-976b-a1426a2fcdc4@isovalent.com>
On Mon, Nov 27, 2023 at 05:07:15PM +0000, Quentin Monnet wrote:
> 2023-11-21 16:42 UTC+0000 ~ Alexei Starovoitov
> <alexei.starovoitov@gmail.com>
> > On Tue, Nov 21, 2023 at 8:26 AM Quentin Monnet <quentin@isovalent.com> wrote:
> >>
> >>>
> >>> Does it have to leave in the kernel tree?
> >>> We have bpftool on github, maybe it can be there?
> >>> Do you want to run bpftool tester as part of BPF CI and that's why
> >>> you want it to be in the kernel tree?
> >>
> >> It doesn't _have_ to be in the kernel tree, although it's a nice place
> >> where to have it. We have bpftool on GitHub, but the CI that runs there
> >> is triggered only when syncing the mirror to check that mirroring is not
> >> broken, so after new patches are applied to bpf-next. If we want this on
> >> GitHub, we would rather target the BPF CI infra.
> >>
> >> A nice point of having it in the repo would be the ability to add tests
> >> at the same time as we add features in bpftool, of course.
> >
> > Sounds nice in theory, but in practice that would mean that
> > every bpftool developer adding a new feature would need to learn rust
> > to add a corresponding test?
> > I suspect devs might object to such a requirement.
>
> True. I've been hoping the tests would look easy enough that devs could
> update them without being particularly versed in Rust, but this is
> probably wishful thinking, and prone to getting bugs in the tests.
>
> I don't have a good proposal to address this, so I agree, this is
> probably not a reasonable requirement.
>
> > If tester and bpftool are not sync then they can be in separate repos.
>
> Makes sense. I'd like to have the tests in the same repo, but for this
> time, let's focus on getting these Rust tests added to the BPF CI infra
> instead, if there's no easy way to switch to a more consensual language.
> Manu, thoughts?
I am fine with that, the work I have done cleaning my original code for this
series is (or at least with minimal changes) self-contained.
Having them hosted outside the tree and used is likely better than nothing.
People can still build upon, and experience will help informing if we should
eventually try to merge this back in.
Manu
>
> Quentin
next prev parent reply other threads:[~2023-12-15 6:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 19:42 [PATCH v1 bpf-next 0/9] bpftool: Add end-to-end testing Manu Bretelle
2023-11-16 19:42 ` [PATCH v1 bpf-next 1/9] bpftool: add testing skeleton Manu Bretelle
2023-11-21 1:37 ` Alexei Starovoitov
2023-11-21 16:26 ` Quentin Monnet
2023-11-21 16:42 ` Alexei Starovoitov
2023-11-21 19:50 ` Andrii Nakryiko
2023-11-27 17:07 ` Quentin Monnet
2023-11-27 18:39 ` Andrii Nakryiko
2023-12-15 6:26 ` Manu Bretelle
2023-11-27 17:07 ` Quentin Monnet
2023-12-15 6:37 ` Manu Bretelle [this message]
2023-11-21 16:26 ` Quentin Monnet
2023-11-16 19:42 ` [PATCH v1 bpf-next 2/9] bpftool: add libbpf-rs dependency and minimal bpf program Manu Bretelle
2023-11-16 19:42 ` [PATCH v1 bpf-next 3/9] bpftool: open and load bpf object Manu Bretelle
2023-11-16 19:42 ` [PATCH v1 bpf-next 4/9] bpftool: Add test to verify that pids are associated to maps Manu Bretelle
2023-11-21 16:26 ` Quentin Monnet
2023-11-16 19:42 ` [PATCH v1 bpf-next 5/9] bpftool: add test for bpftool prog Manu Bretelle
2023-11-21 16:26 ` Quentin Monnet
2023-11-16 19:42 ` [PATCH v1 bpf-next 6/9] bpftool: test that we can dump and read the content of a map Manu Bretelle
2023-11-21 16:26 ` Quentin Monnet
2023-11-16 19:42 ` [PATCH v1 bpf-next 7/9] bpftool: Add struct_ops tests Manu Bretelle
2023-11-16 19:42 ` [PATCH v1 bpf-next 8/9] bpftool: Add bpftool_tests README.md Manu Bretelle
2023-11-21 16:26 ` Quentin Monnet
2023-11-16 19:42 ` [PATCH v1 bpf-next 9/9] bpftool: Add Makefile to facilitate bpftool_tests usage Manu Bretelle
2023-11-21 16:26 ` Quentin Monnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXv0E0+npdrWNEvh@surya \
--to=chantr4@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=quentin@isovalent.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox