Re: [PATCH dwarves v3] pahole: Inject kfunc decl tags into BTF

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Mon, Jan 29, 2024 at 01:05:05PM +0000, Alan Maguire escreveu:
> This should probably be a BTF feature supported by --btf_features; that
> way we'd have a mechanism to switch it off if needed. Can you look at
> adding a "tag_kfunc" or whatever name suits into the btf_features[]
> array in pahole.c?  Something like:
 
> 	BTF_FEATURE(tag_kfunc, btf_tag_kfunc, false),
 
> You'll also then need to add a btf_tag_kfunc boolean field to
> struct conf_load, and generation of kfunc tags should then be guarded by
 
> if (conf_load->btf_tag_kfunc)
 
> ...so that the tags are added conditionally depending on whether
> the user wants them.
 
> Then if a user specifies --btf_features=all or some subset of BTF
> features including "tag_kfunc" they will get kfunc tags.

Agreed.
 
> We probably should also move to using --btf_features instead of the
> current combination of "--" parameters when pahole is bumped to v1.26.

Alan, talking about that, I guess we better tag v1.26 before merging
this new kfunc work, wdyt?

- Arnaldo