From: Manu Bretelle <chantr4@gmail.com>
To: Yan Zhai <yan@cloudflare.com>
Cc: bpf@vger.kernel.org, andrii@kernel.org, daniel@iogearbox.net,
ast@kernel.org, martin.lau@linux.dev, song@kernel.org,
eddyz87@gmail.com, john.fastabend@gmail.com, kpsingh@kernel.org,
sdf@google.com, haoluo@google.com, jolsa@kernel.org
Subject: Re: [PATCH bpf-next ] selftests/bpf: disable IPv6 for lwt_redirect test
Date: Thu, 1 Feb 2024 10:42:47 -0800 [thread overview]
Message-ID: <ZbvmJwy96KPluVqO@surya> (raw)
In-Reply-To: <CAO3-PboMzPXAey7a1LQ1Gme_pgV4QMyFBx-y=R7PUQBPrGfRvg@mail.gmail.com>
On Wed, Jan 31, 2024 at 10:44:07PM -0600, Yan Zhai wrote:
> >
> > diff --git a/tools/testing/selftests/bpf/prog_tests/lwt_redirect.c b/tools/testing/selftests/bpf/prog_tests/lwt_redirect.c
> > index beeb3ac1c361..b5b9e74b1044 100644
> > --- a/tools/testing/selftests/bpf/prog_tests/lwt_redirect.c
> > +++ b/tools/testing/selftests/bpf/prog_tests/lwt_redirect.c
> > @@ -203,6 +203,7 @@ static int setup_redirect_target(const char *target_dev, bool need_mac)
> > if (!ASSERT_GE(target_index, 0, "if_nametoindex"))
> > goto fail;
> >
> > + SYS(fail, "sysctl -w net.ipv6.conf.all.disable_ipv6=1");
>
> Thanks for digging into this! I was totally unprepared for that many
> router solicitations when I wrote the wait logic. For now disable v6
> is totally good to unblock similar scenarios. But think it twice it is
> probably still worthwhile to incorporate v6 later since lwt hooks mess
> with both v4/v6 routing. So I'll try to fix up the wait logic later
> this week. An exact packet filter is probably best suited to make
> icmpv6/arp/nd happy.
>
Greatly appreciated Yan. I definitely agree that it is desirable to have V6
support to.
In case that helps... [0] should help you repro locally on your favorite
architecture.
[0] https://chantra.github.io/bpfcitools/bpf-local-development.html
Manu
> best
> Yan
>
> > SYS(fail, "ip link add link_err type dummy");
> > SYS(fail, "ip link set lo up");
> > SYS(fail, "ip addr add dev lo " LOCAL_SRC "/32");
> > --
> > 2.39.3
> >
prev parent reply other threads:[~2024-02-01 18:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 5:32 [PATCH bpf-next ] selftests/bpf: disable IPv6 for lwt_redirect test Manu Bretelle
2024-01-31 17:20 ` patchwork-bot+netdevbpf
2024-01-31 17:49 ` Alan Maguire
2024-01-31 18:50 ` Manu Bretelle
2024-02-01 4:44 ` Yan Zhai
2024-02-01 18:42 ` Manu Bretelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbvmJwy96KPluVqO@surya \
--to=chantr4@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yan@cloudflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox