From: Baoquan He <bhe@redhat.com>
To: Stanislav Fomichev <sdf@google.com>
Cc: Hari Bathini <hbathini@linux.ibm.com>,
bpf@vger.kernel.org, Kexec-ml <kexec@lists.infradead.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH linux-next] bpf: fix warning for crash_kexec
Date: Sat, 10 Feb 2024 12:51:21 +0800 [thread overview]
Message-ID: <ZccAyalp+NyKQoGp@MiWiFi-R3L-srv> (raw)
In-Reply-To: <ZcZ6myvln-v0Y98S@google.com>
On 02/09/24 at 11:18am, Stanislav Fomichev wrote:
> On 02/09, Hari Bathini wrote:
> > With [1], CONFIG_KEXEC & !CONFIG_CRASH_DUMP is supported but that led
> > to the below warning:
> >
> > "WARN: resolve_btfids: unresolved symbol crash_kexec"
> >
> > Fix it by using the appropriate #ifdef.
>
> Same question here: how did you find this particular kconfig option
> (CONFIG_CRASH_DUMP) to use? Looking at the code, crash_kexec is defined
> in kernel/kexec_core.c and it's gated by CONFIG_KEXEC_CORE. So the
> existing ifdef seems correct?
This patch is based on the latest next tree, I have made some changes to
split the crash code from kexec_core.c. If you check next/master branch,
crash_kexec is not in kernel/keec_core.c any more.
next prev parent reply other threads:[~2024-02-10 4:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 12:35 [PATCH linux-next] bpf: fix warning for crash_kexec Hari Bathini
2024-02-09 19:18 ` Stanislav Fomichev
2024-02-10 4:51 ` Baoquan He [this message]
2024-02-12 8:44 ` Jiri Olsa
2024-02-12 16:48 ` Stanislav Fomichev
2024-02-10 4:52 ` Baoquan He
2024-03-18 6:52 ` Hari Bathini
2024-03-18 16:13 ` Yonghong Song
2024-03-19 8:06 ` Hari Bathini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZccAyalp+NyKQoGp@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hbathini@linux.ibm.com \
--cc=kexec@lists.infradead.org \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox