Re: [PATCH v2 bpf-next] bpf: add a verbose message if map limit is reached

[Anton Protopopov <aspsk@isovalent.com>]

On Mon, Apr 01, 2024 at 06:49:53PM -0700, John Fastabend wrote:
> Anton Protopopov wrote:
> > When more than 64 maps are used by a program and its subprograms the
> > verifier returns -E2BIG. Add a verbose message which highlights the
> > source of the error and also print the actual limit.
> > 
> > v1 -> v2:
> >   * make the message more clear (Alexey)
> > 
> > Signed-off-by: Anton Protopopov <aspsk@isovalent.com>
> > Acked-by: Yonghong Song <yonghong.song@linux.dev>
> > ---
> >  kernel/bpf/verifier.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> > index edb650667f44..559526191ae7 100644
> > --- a/kernel/bpf/verifier.c
> > +++ b/kernel/bpf/verifier.c
> > @@ -18348,6 +18348,8 @@ static int resolve_pseudo_ldimm64(struct bpf_verifier_env *env)
> >  			}
> >  
> >  			if (env->used_map_cnt >= MAX_USED_MAPS) {
> > +				verbose(env, "The total number of maps per program is reached the limit of %u\n",
> > +					MAX_USED_MAPS);
> >  				fdput(f);
> >  				return -E2BIG;
> >  			}
> > -- 
> > 2.34.1
> > 
> > 
> 
> LGTM thanks.
> 
> Acked-by: John Fastabend <john.fastabend@gmail.com>

Thanks. I will actually send yet another version, hopefully
the last, with 'has reached' instead of 'is reached'