BPF List
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>,
	intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Richard Cochran <richardcochran@gmail.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	John Fastabend <john.fastabend@gmail.com>
Subject: Re: [PATCH net-next v1 1/1] net: intel: Use *-y instead of *-objs in Makefile
Date: Wed, 8 May 2024 17:25:31 +0300	[thread overview]
Message-ID: <ZjuLW8jA3MuT0oih@smile.fi.intel.com> (raw)
In-Reply-To: <6ac025de-9264-4510-ba7f-f9a56c564a80@intel.com>

On Wed, May 08, 2024 at 03:35:26PM +0200, Alexander Lobakin wrote:
> > *-objs suffix is reserved rather for (user-space) host programs while
> > usually *-y suffix is used for kernel drivers (although *-objs works
> > for that purpose for now).
> > 
> > Let's correct the old usages of *-objs in Makefiles.
> 
> Wait, I was sure I've seen somewhere that -objs is more new and
> preferred over -y. 

Then you are mistaken.

> See recent dimlib comment where Florian changed -y to
> -objs for example.

So does he :-)

> Any documentation reference that -objs is for userspace and we should
> clearly use -y?

Sure. Luckily it's documented in Documentation/kbuild/makefiles.rst
"Composite Host Programs" (mind the meaning of the word "host"!).

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2024-05-08 14:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-08 13:23 [PATCH net-next v1 1/1] net: intel: Use *-y instead of *-objs in Makefile Andy Shevchenko
2024-05-08 13:35 ` Alexander Lobakin
2024-05-08 14:25   ` Andy Shevchenko [this message]
2024-05-08 14:39     ` Alexander Lobakin
2024-05-08 14:40       ` Alexander Lobakin
2024-05-08 14:42         ` [Intel-wired-lan] " Loktionov, Aleksandr
2024-05-08 17:58           ` Jacob Keller
2024-05-08 18:02             ` Andy Shevchenko
2024-05-08 17:28 ` kernel test robot
2024-05-08 17:56   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZjuLW8jA3MuT0oih@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=aleksander.lobakin@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hawk@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox