BPF List
 help / color / mirror / Atom feed
From: Jiri Olsa <olsajiri@gmail.com>
To: Rafael Passos <rafael@rcpassos.me>
Cc: andrii@kernel.org, ast@kernel.org, bjorn@kernel.org,
	bp@alien8.de, daniel@iogearbox.net, davem@davemloft.net,
	dsahern@kernel.org, mingo@redhat.com, puranjay@kernel.org,
	tglx@linutronix.de, will@kernel.org, xi.wang@gmail.com,
	bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next V2 0/3] Fix compiler warnings, looking for suggestions
Date: Mon, 17 Jun 2024 10:45:16 +0200	[thread overview]
Message-ID: <Zm_3nE-ho-MDZbyp@krava> (raw)
In-Reply-To: <20240615022641.210320-1-rafael@rcpassos.me>

On Fri, Jun 14, 2024 at 11:24:07PM -0300, Rafael Passos wrote:
> Hi,
> This patchset has a few fixes to compiler warnings.

curious, which compiler/setup displayed the warnings?

> I am studying the BPF subsystem and wish to bring more tangible contributions.
> I would appreciate receiving suggestions on things to investigate.
> I also documented a bit in my blog. I could help with docs here, too.
> https://rcpassos.me/post/linux-ebpf-understanding-kernel-level-mechanics
> Thanks!
> 
> Changelog V1 -> V2:
> - rebased all commits to updated for-next base
> - removes new cases of the extra parameter for bpf_jit_binary_pack_finalize
> - built and tested for ARM64
> - sent the series for the test workflow:
>   https://github.com/kernel-patches/bpf/pull/7198
> 
> 
> Rafael Passos (3):
>   bpf: remove unused parameter in bpf_jit_binary_pack_finalize
>   bpf: remove unused parameter in __bpf_free_used_btfs
>   bpf: remove redeclaration of new_n in bpf_verifier_vlog

lgtm, nice cleanup

Acked-by: Jiri Olsa <jolsa@kernel.org>

jirka


> 
>  arch/arm64/net/bpf_jit_comp.c   | 3 +--
>  arch/powerpc/net/bpf_jit_comp.c | 4 ++--
>  arch/riscv/net/bpf_jit_core.c   | 5 ++---
>  arch/x86/net/bpf_jit_comp.c     | 4 ++--
>  include/linux/bpf.h             | 3 +--
>  include/linux/filter.h          | 3 +--
>  kernel/bpf/core.c               | 8 +++-----
>  kernel/bpf/log.c                | 2 +-
>  kernel/bpf/verifier.c           | 3 +--
>  9 files changed, 14 insertions(+), 21 deletions(-)
> 
> -- 
> 2.45.2
> 
> 

  parent reply	other threads:[~2024-06-17  8:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-15  2:24 [PATCH bpf-next V2 0/3] Fix compiler warnings, looking for suggestions Rafael Passos
2024-06-15  2:24 ` [PATCH bpf-next V2 1/3] bpf: remove unused parameter in bpf_jit_binary_pack_finalize Rafael Passos
2024-06-15  2:24 ` [PATCH bpf-next V2 2/3] bpf: remove unused parameter in __bpf_free_used_btfs Rafael Passos
2024-06-15  2:24 ` [PATCH bpf-next V2 3/3] bpf: remove redeclaration of new_n in bpf_verifier_vlog Rafael Passos
2024-06-17  8:45 ` Jiri Olsa [this message]
2024-06-18  2:34   ` [PATCH bpf-next V2 0/3] Fix compiler warnings, looking for suggestions Rafael Passos
2024-06-18 14:20 ` Puranjay Mohan
2024-06-21  3:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zm_3nE-ho-MDZbyp@krava \
    --to=olsajiri@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bjorn@kernel.org \
    --cc=bp@alien8.de \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=mingo@redhat.com \
    --cc=puranjay@kernel.org \
    --cc=rafael@rcpassos.me \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    --cc=xi.wang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox