Re: [PATCH net-next 3/4] igb: add AF_XDP zero-copy Rx support

Maciej Fijalkowski
2024-08-14T08:56:01Z

On Wed, Aug 14, 2024 at 10:29:29AM +0200, Kurt Kanzenbach wrote:
> >> case XDP_REDIRECT:
> >> err = xdp_do_redirect(adapter->netdev, xdp, xdp_prog);
> >
> > We were introducing a ZC variant of handling XDP verdict due to a fact
> > that mostly what happens is the redirect to user space. We observed a
> > reasonable perf improvement from likely()fying XDP_REDIRECT case.
>
> Indeed, I can observe an improvement too.
>
> I've introduced igb_run_xdp_zc() which takes care of that
> optimization. Also it takes a pointer to the (read once) xsk_pool to
> address the other comment.

Nice, thanks!

>
> Thanks,
> Kurt