From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3127214D42C; Tue, 2 Jul 2024 16:05:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719936311; cv=none; b=E0TX/Nnf6xAwr1ZOZ6p2jYVQBoY+pHB9EyHcHW/DIyzOr5DDE0O4c+q/HkEMbXHeVxmiB5noGpbLFYlgXphyHIMCWc68CLfxSx/nHUbv+s5BYj9m2sJCIyK8k3FMGkg3La7r71str/jc/95151npPkWe9r0DrajR/aqRxlF8lZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719936311; c=relaxed/simple; bh=gcPZu10Fun4CSdDBFTvZqP809dlNmXQL0R/O6Jbl7Pg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RT2FAHSQYOfQrtzFsAlqqLsj220mzodc/XQ3csFo47LiC2K3BQNP5/wak2nOoyYdXmqAheCzSLvV+tuMdK+iN9sPXEvgyHzBgqm+3xHftn8lzShs4qr9Mw3crPU6bj5Ok/2FFdoK3zs8+boc9Gt5mfx/bRoU+5K3h2Z4jI7XD3Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l2KpePO4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l2KpePO4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00769C116B1; Tue, 2 Jul 2024 16:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719936311; bh=gcPZu10Fun4CSdDBFTvZqP809dlNmXQL0R/O6Jbl7Pg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=l2KpePO4t11G+vPXMFznq4GeBoJO+vQ3xre1jn9wq1fRsZicA0Wjr47jXlP5PhU+W QC0jr6l+vpiAd6aXVRWleW/v6gSjtOJIDzyG6U0jlLDEPxutoY2KXORErqZ1JYMwVJ zhDbA0HG881HGqW05bW6cW+CrdH8Bf/FIXkPH4tQfzKDSVaqZdXKAK41Ns9Nkk6DW3 fUBHGjkqckjwS9EQUqE9PZskNLN8JYftzWRUYRm6hlb/tpw5PA3arpZ5IGjlTnWVpb K/1BVvzzZEHWbJIRm/6ZauoiSl8Hg/vf5cTx4pIc6gNOlfRGZTk4B7jV1Dlhm/qCD1 bPuPa0Gu8eUSg== Message-ID: Date: Tue, 2 Jul 2024 17:05:06 +0100 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH bpf-next] bpftool: Mount bpffs when pinmaps path not under the bpffs To: Tao Chen Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , bpf@vger.kernel.org, Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , linux-kernel@vger.kernel.org References: <20240702131150.15622-1-chen.dylane@gmail.com> From: Quentin Monnet Content-Language: en-GB In-Reply-To: <20240702131150.15622-1-chen.dylane@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 02/07/2024 14:11, Tao Chen wrote: > As qmonnet said [1], map pinning will fail if the pinmaps path not under > the bpffs, like: > libbpf: specified path /home/ubuntu/test/sock_ops_map is not on BPF FS > Error: failed to pin all maps > [1]: https://github.com/libbpf/bpftool/issues/146 > > Fixes: 3767a94b3253 ("bpftool: add pinmaps argument to the load/loadall") > Signed-off-by: Tao Chen The patch looks good, thank you! Tested-by: Quentin Monnet Reviewed-by: Quentin Monnet