From: Eduard Zingerman <eddyz87@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
daniel@iogearbox.net, martin.lau@linux.dev, kernel-team@fb.com,
yonghong.song@linux.dev
Subject: Re: [PATCH bpf-next v1 2/3] veristat: strerror expects positive number (errno)
Date: Fri, 28 Feb 2025 14:46:18 -0800 [thread overview]
Message-ID: <a179f92b973280cc6fa7a27fa4bc822bbc40f025.camel@gmail.com> (raw)
In-Reply-To: <CAEf4BzZJGYxQxjjc4p=kmN0aUVNCHeP5xgPtHEBteswjt=K_sA@mail.gmail.com>
On Fri, 2025-02-28 at 14:44 -0800, Andrii Nakryiko wrote:
[...]
> > diff --git a/tools/testing/selftests/bpf/veristat.c b/tools/testing/selftests/bpf/veristat.c
> > index 8bc462299290..7d13b9234d2c 100644
> > --- a/tools/testing/selftests/bpf/veristat.c
> > +++ b/tools/testing/selftests/bpf/veristat.c
> > @@ -660,7 +660,7 @@ static int append_filter_file(const char *path)
> > f = fopen(path, "r");
> > if (!f) {
> > err = -errno;
> > - fprintf(stderr, "Failed to open filters in '%s': %s\n", path, strerror(err));
> > + fprintf(stderr, "Failed to open filters in '%s': %s\n", path, strerror(errno));
>
> errno is fragile, -err would be more robust, IMO
Sure, I'll send v2.
[...]
next prev parent reply other threads:[~2025-02-28 22:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 19:12 [PATCH bpf-next v1 0/3] veristat: @files-list.txt notation for object files list Eduard Zingerman
2025-02-28 19:12 ` [PATCH bpf-next v1 1/3] " Eduard Zingerman
2025-02-28 19:12 ` [PATCH bpf-next v1 2/3] veristat: strerror expects positive number (errno) Eduard Zingerman
2025-02-28 22:44 ` Andrii Nakryiko
2025-02-28 22:46 ` Eduard Zingerman [this message]
2025-02-28 19:12 ` [PATCH bpf-next v1 3/3] veristat: report program type guess results to sdterr Eduard Zingerman
2025-02-28 22:47 ` [PATCH bpf-next v1 0/3] veristat: @files-list.txt notation for object files list Andrii Nakryiko
2025-02-28 23:00 ` Eduard Zingerman
2025-02-28 23:10 ` Andrii Nakryiko
2025-02-28 23:33 ` Mykyta Yatsenko
2025-03-01 0:03 ` Eduard Zingerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a179f92b973280cc6fa7a27fa4bc822bbc40f025.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@linux.dev \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox