From: Yonghong Song <yonghong.song@linux.dev>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <kernel-team@fb.com>,
Martin KaFai Lau <martin.lau@kernel.org>,
Daniel Hodges <hodgesd@meta.com>
Subject: Re: [PATCH bpf-next v2 1/2] bpf, x64: Fix a jit convergence issue
Date: Wed, 4 Sep 2024 11:32:07 -0700 [thread overview]
Message-ID: <a18f6bb9-2b9e-4f30-9cb4-20c326cf49b6@linux.dev> (raw)
In-Reply-To: <CAADnVQ+iqrfTgvPieBz8cTpdUdU94tTrFW88xttwthqmtx2Qwg@mail.gmail.com>
On 9/4/24 9:56 AM, Alexei Starovoitov wrote:
> On Tue, Sep 3, 2024 at 4:00 PM Yonghong Song <yonghong.song@linux.dev> wrote:
>>
>> diff --git a/arch/x86/net/bpf_jit_comp.c b/arch/x86/net/bpf_jit_comp.c
>> index 074b41fafbe3..63c4816ed4e7 100644
>> --- a/arch/x86/net/bpf_jit_comp.c
>> +++ b/arch/x86/net/bpf_jit_comp.c
>> @@ -64,6 +64,57 @@ static bool is_imm8(int value)
>> return value <= 127 && value >= -128;
>> }
>>
>> +/*
>> + * Let us limit the positive offset to be <= 124.
> I think the comment will read better if the above says "<= 123",
> since that's the final outcome.
> 124 above is a bit confusing.
> I can tweak while applying if you agree.
Correct. Let us do "<= 123".
>
>> + * to mamximum 123 (0x7b). This way, the jit pass can eventually converge.
> Can fix this typo too.
Sounds good.
Since I need to change test in the second patch (enabling tests for arm64/s390),
let me send v3 to address all comments.
prev parent reply other threads:[~2024-09-04 18:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 22:59 [PATCH bpf-next v2 1/2] bpf, x64: Fix a jit convergence issue Yonghong Song
2024-09-03 22:59 ` [PATCH bpf-next v2 2/2] selftests/bpf: Add a selftest for x86 jit convergence issues Yonghong Song
2024-09-04 16:58 ` Alexei Starovoitov
2024-09-04 18:28 ` Yonghong Song
2024-09-04 16:56 ` [PATCH bpf-next v2 1/2] bpf, x64: Fix a jit convergence issue Alexei Starovoitov
2024-09-04 18:32 ` Yonghong Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a18f6bb9-2b9e-4f30-9cb4-20c326cf49b6@linux.dev \
--to=yonghong.song@linux.dev \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hodgesd@meta.com \
--cc=kernel-team@fb.com \
--cc=martin.lau@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox