From: Alan Maguire <alan.maguire@oracle.com>
To: bot+bpf-ci@kernel.org, qmo@kernel.org
Cc: kpsingh@kernel.org, ast@kernel.org, andrii@kernel.org,
daniel@iogearbox.net, martin.lau@linux.dev, eddyz87@gmail.com,
song@kernel.org, yonghong.song@linux.dev,
john.fastabend@gmail.com, sdf@fomichev.me, haoluo@google.com,
jolsa@kernel.org, bpf@vger.kernel.org, martin.lau@kernel.org,
clm@meta.com, ihor.solodrai@linux.dev
Subject: Re: [PATCH bpf-next 2/2] selftests/bpf: Allow selftests to build with older xxd
Date: Sat, 15 Nov 2025 11:46:26 +0000 [thread overview]
Message-ID: <a1a17528-cfcc-42e4-91b1-1004a1487f6e@oracle.com> (raw)
In-Reply-To: <ab8f0f2626eea5beee45b6c6418f976a3cf060aba80320d0d9f13ebb814a9436@mail.kernel.org>
On 14/11/2025 23:06, bot+bpf-ci@kernel.org wrote:
>> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
>> index 34ea23c63..8687c17c5 100644
>> --- a/tools/testing/selftests/bpf/Makefile
>> +++ b/tools/testing/selftests/bpf/Makefile
>> @@ -731,7 +731,8 @@ $(VERIFICATION_CERT) $(PRIVATE_KEY): $(VERIFY_SIG_SETUP)
>> $(Q)$(VERIFY_SIG_SETUP) genkey $(BUILD_DIR)
>>
>> $(VERIFY_SIG_HDR): $(VERIFICATION_CERT)
>> - $(Q)xxd -i -n test_progs_verification_cert $< > $@
>> + $(Q)ln -fs $< test_progs_verification_cert && \
>> + xxd -i test_progs_verification_cert > $@
>
> Should the symlink test_progs_verification_cert be added to the cleanup
> targets? Currently it's not included in EXTRA_CLEAN (lines 903-909), so
> after running "make clean" the symlink will remain as a dangling link in
> the source tree. This will appear as an untracked file in git status and
> is not present in .gitignore.
>
yep, adding the symlink to EXTRA_CLEAN in Makefile and .gitignore is a
good catch; I'll wait to see if there's additional feedback before
sending a v2 with those changes.
Alan
>
> ---
> AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
> See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
>
> CI run summary: https://github.com/kernel-patches/bpf/actions/runs/19379374420
prev parent reply other threads:[~2025-11-15 11:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 22:22 [PATCH bpf-next 0/2] Ease BPF signing build requirements Alan Maguire
2025-11-14 22:22 ` [PATCH bpf-next 1/2] bpftool: Allow bpftool to build with openssl < 3 Alan Maguire
2025-11-14 22:55 ` Song Liu
2025-11-14 23:03 ` Alan Maguire
2025-11-14 23:17 ` Song Liu
2025-11-17 11:53 ` Quentin Monnet
2025-11-14 22:22 ` [PATCH bpf-next 2/2] selftests/bpf: Allow selftests to build with older xxd Alan Maguire
2025-11-14 23:06 ` bot+bpf-ci
2025-11-15 11:46 ` Alan Maguire [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1a17528-cfcc-42e4-91b1-1004a1487f6e@oracle.com \
--to=alan.maguire@oracle.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bot+bpf-ci@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clm@meta.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=ihor.solodrai@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=qmo@kernel.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox