From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: "Zaremba, Larysa" <larysa.zaremba@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Cc: "intel-wired-lan@osuosl.org" <intel-wired-lan@osuosl.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
"Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>
Subject: Re: [PATCH net] ice: xsk: Fix cleaning of XDP_TX frames
Date: Thu, 9 Feb 2023 09:20:27 -0800 [thread overview]
Message-ID: <a2af75b3-3dc2-0e83-558f-2b9a4ccfe5c7@intel.com> (raw)
In-Reply-To: <20230209160130.1779890-1-larysa.zaremba@intel.com>
On 2/9/2023 8:01 AM, Zaremba, Larysa wrote:
> Incrementation of xsk_frames inside the for-loop produces
> infinite loop, if we have both normal AF_XDP-TX and XDP_TXed
> buffers to complete.
>
> Split xsk_frames into 2 variables (xsk_frames and completed_frames)
> to eliminate this bug.
>
> Fixes: 29322791bc8b ("ice: xsk: change batched Tx descriptor cleaning")
> Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
> ---
> To Tony: this is urgent and should go directly via net. It's tested and acked.
netdev maintainers,
Since it's been tested and reviewed, did you want to take this directly?
Acked-by: Tony Nguyen <anthony.l.nguyen@intel.com>
next prev parent reply other threads:[~2023-02-09 17:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 16:01 [PATCH net] ice: xsk: Fix cleaning of XDP_TX frames Larysa Zaremba
2023-02-09 17:07 ` Alexander H Duyck
2023-02-09 17:20 ` Tony Nguyen [this message]
2023-02-09 18:00 ` Jakub Kicinski
2023-02-11 4:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2af75b3-3dc2-0e83-558f-2b9a4ccfe5c7@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=alexandr.lobakin@intel.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@osuosl.org \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox