From: Quentin Monnet <qmo@kernel.org>
To: chenyuan <chenyuan_fl@163.com>,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
yonghong.song@linux.dev
Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
Yuan Chen <chenyuan@kylinos.cn>
Subject: Re: [PATCH v5] bpftool: Add CET-aware symbol matching for x86_64 architectures
Date: Wed, 23 Jul 2025 11:24:14 +0100 [thread overview]
Message-ID: <a55fde07-9320-46b0-bf7c-a2fdfb7c79b2@kernel.org> (raw)
In-Reply-To: <20250723022043.20503-1-chenyuan_fl@163.com>
Your message had a
"Reply-To: <aef2617b-ce03-4830-96a7-39df0c93aaad@kernel.org>" header, I
ignored it. I believe you meant to have In-Reply-To: instead.
2025-07-23 10:20 UTC+0800 ~ chenyuan_fl@163.com
> From: Yuan Chen <chenyuan@kylinos.cn>
>
> Adjust symbol matching logic to account for Control-flow Enforcement
> Technology (CET) on x86_64 systems. CET prefixes functions with
> a 4-byte 'endbr' instruction, shifting the actual hook entry point to
> symbol + 4.
>
> Changed in PATCH v4:
> * Refactor repeated code into a function.
> * Add detection for the x86 architecture.
>
> Changed int PATH v5:
> * Remove detection for the x86 architecture.
>
> Signed-off-by: Yuan Chen <chenyuan@kylinos.cn>
> ---
Looks good from my side, thank you!
Reviewed-by: Quentin Monnet <qmo@kernel.org>
Probably worth waiting for Yonghong's ack as well before merging this patch.
next prev parent reply other threads:[~2025-07-23 10:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 2:20 [PATCH v5] bpftool: Add CET-aware symbol matching for x86_64 architectures chenyuan_fl
2025-07-23 10:24 ` Quentin Monnet [this message]
2025-07-23 13:08 ` Jiri Olsa
2025-07-23 15:52 ` Yonghong Song
2025-08-15 2:52 ` [PATCH 0/2] bpftool: Refactor config parsing and add CET symbol matching chenyuan_fl
2025-08-15 2:52 ` [PATCH v6 1/2] bpftool: Refactor kernel config reading into common helper chenyuan_fl
2025-08-15 2:52 ` [PATCH v6 2/2] bpftool: Add CET-aware symbol matching for x86_64 architectures chenyuan_fl
2025-08-18 9:55 ` Jiri Olsa
2025-08-25 2:20 ` [PATCH v7 0/2] bpftool: Refactor config parsing and add CET symbol matching chenyuan_fl
2025-08-25 2:20 ` [PATCH v7 1/2] bpftool: Refactor kernel config reading into common helper chenyuan_fl
2025-08-25 20:29 ` Yonghong Song
2025-08-25 2:20 ` [PATCH v7 2/2] bpftool: Add CET-aware symbol matching for x86_64 architectures chenyuan_fl
2025-08-25 20:39 ` Yonghong Song
2025-08-25 22:44 ` [PATCH v7 0/2] bpftool: Refactor config parsing and add CET symbol matching Jiri Olsa
2025-08-27 21:53 ` Andrii Nakryiko
2025-08-28 21:50 ` Quentin Monnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a55fde07-9320-46b0-bf7c-a2fdfb7c79b2@kernel.org \
--to=qmo@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chenyuan@kylinos.cn \
--cc=chenyuan_fl@163.com \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).