BPF List
 help / color / mirror / Atom feed
From: Yonghong Song <yonghong.song@linux.dev>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>, bpf@vger.kernel.org
Cc: daniel@iogearbox.net, andrii@kernel.org, martin.lau@kernel.org
Subject: Re: [PATCH bpf-next] selftests/bpf: Fix failure path in send_signal test
Date: Thu, 13 Nov 2025 13:59:22 -0800	[thread overview]
Message-ID: <a6ab4444-f3b4-49ae-84a8-8f7924267180@linux.dev> (raw)
In-Reply-To: <20251113070531.46573-1-alexei.starovoitov@gmail.com>



On 11/12/25 11:05 PM, Alexei Starovoitov wrote:
> From: Alexei Starovoitov <ast@kernel.org>
>
> When test_send_signal_kern__open_and_load() fails parent closes the
> pipe which cases ASSERT_EQ(read(pipe_p2c...)) to fail, but child
> continues and enters infinite loop, while parent is stuck in wait(NULL).
>
> Fix the issue by killing the child before jumping to skel_open_load_failure.
>
> The bug was discovered while compiling all of selftests with -O1 instead of -O2
> which caused progs/test_send_signal_kern.c to fail to load.
>
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>

I can reproduce the hang with -O1 and this patch fixed it. So

Tested-by: Yonghong Song <yonghong.song@linux.dev>


  parent reply	other threads:[~2025-11-13 21:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13  7:05 [PATCH bpf-next] selftests/bpf: Fix failure path in send_signal test Alexei Starovoitov
2025-11-13  7:31 ` bot+bpf-ci
2025-11-13 21:59 ` Yonghong Song [this message]
2025-11-14 22:20 ` Andrii Nakryiko
2025-11-14 22:25   ` Alexei Starovoitov
2025-11-15  1:02     ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6ab4444-f3b4-49ae-84a8-8f7924267180@linux.dev \
    --to=yonghong.song@linux.dev \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=martin.lau@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox