From: Eduard Zingerman <eddyz87@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Kernel Team <kernel-team@fb.com>,
Yonghong Song <yonghong.song@linux.dev>,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH bpf-next v1 1/3] bpf: simple DFA-based live registers analysis
Date: Fri, 28 Feb 2025 18:09:20 -0800 [thread overview]
Message-ID: <a6fa86df063295d702365009bfd5936ffa5e083b.camel@gmail.com> (raw)
In-Reply-To: <CAADnVQJRFCn39RMPRydcopX-UY0h_s3AvCMhwcfc7YGQt-JcoA@mail.gmail.com>
On Fri, 2025-02-28 at 18:01 -0800, Alexei Starovoitov wrote:
> On Thu, Feb 27, 2025 at 10:01 PM Eduard Zingerman <eddyz87@gmail.com> wrote:
[...]
> > @@ -3379,10 +3388,7 @@ static int check_subprogs(struct bpf_verifier_env *env)
> > goto next;
> > if (BPF_OP(code) == BPF_EXIT || BPF_OP(code) == BPF_CALL)
> > goto next;
> > - if (code == (BPF_JMP32 | BPF_JA))
> > - off = i + insn[i].imm + 1;
> > - else
> > - off = i + insn[i].off + 1;
> > + off = i + jmp_offset(&insn[i]) + 1;
>
> Nice cleanup, but pls split it into pre-patch,
> so that main liveness logic is in the main patch.
Thanks for the feedback.
I'll include all requested changes in v2.
[...]
next prev parent reply other threads:[~2025-03-01 2:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 6:00 [PATCH bpf-next v1 0/3] bpf: simple DFA-based live registers analysis Eduard Zingerman
2025-02-28 6:00 ` [PATCH bpf-next v1 1/3] " Eduard Zingerman
2025-03-01 2:01 ` Alexei Starovoitov
2025-03-01 2:09 ` Eduard Zingerman [this message]
2025-02-28 6:00 ` [PATCH bpf-next v1 2/3] bpf: use register liveness information for func_states_equal Eduard Zingerman
2025-02-28 6:00 ` [PATCH bpf-next v1 3/3] selftests/bpf: test cases for compute_live_registers() Eduard Zingerman
2025-03-01 2:10 ` [PATCH bpf-next v1 0/3] bpf: simple DFA-based live registers analysis Alexei Starovoitov
2025-03-01 4:40 ` Eduard Zingerman
2025-03-02 0:09 ` Alexei Starovoitov
2025-03-03 19:28 ` Eduard Zingerman
2025-03-05 9:00 ` Eduard Zingerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6fa86df063295d702365009bfd5936ffa5e083b.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@linux.dev \
--cc=tj@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox