BPF List
 help / color / mirror / Atom feed
From: Eduard Zingerman <eddyz87@gmail.com>
To: Manu Bretelle <chantr4@gmail.com>,
	bpf@vger.kernel.org,  quentin@isovalent.com, andrii@kernel.org,
	daniel@iogearbox.net, ast@kernel.org,  martin.lau@linux.dev,
	song@kernel.org, john.fastabend@gmail.com,  kpsingh@kernel.org,
	sdf@google.com, haoluo@google.com, jolsa@kernel.org
Subject: Re: [PATCH bpf-next 0/2] bpftool: Fix some json formatting for struct_ops
Date: Thu, 19 Oct 2023 15:56:04 +0300	[thread overview]
Message-ID: <a8e684361c0a006971aa55afddda347e59a2ef79.camel@gmail.com> (raw)
In-Reply-To: <20231018230133.1593152-1-chantr4@gmail.com>

On Wed, 2023-10-18 at 16:01 -0700, Manu Bretelle wrote:
> When dumping struct_ops with bpftool, the json produced was invalid.
> 1) pointer values where not printed with surrounding quotes, causing an
> invalid json integer to be emitted
> 2) when bpftool struct_ops dump id <id>, the 2 dictionaries were not
> wrapped in a array, here also causing an invalid json payload to be
> emitted. 

Acked-by: Eduard Zingerman <eddyz87@gmail.com>

Hi Manu,

I've tested this patch-set and everything seems to work as expected.

Thanks,
Eduard

> Manu Bretelle (2):
>   bpftool: fix printing of pointer value
>   bpftool: wrap struct_ops dump in an array
> 
>  tools/bpf/bpftool/btf_dumper.c | 2 +-
>  tools/bpf/bpftool/struct_ops.c | 6 ++++++
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 


  parent reply	other threads:[~2023-10-19 12:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18 23:01 [PATCH bpf-next 0/2] bpftool: Fix some json formatting for struct_ops Manu Bretelle
2023-10-18 23:01 ` [PATCH bpf-next 1/2] bpftool: fix printing of pointer value Manu Bretelle
2023-10-18 23:01 ` [PATCH bpf-next 2/2] bpftool: wrap struct_ops dump in an array Manu Bretelle
2023-10-19 12:56 ` Eduard Zingerman [this message]
2023-10-19 14:28 ` [PATCH bpf-next 0/2] bpftool: Fix some json formatting for struct_ops Quentin Monnet
2023-10-19 14:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8e684361c0a006971aa55afddda347e59a2ef79.camel@gmail.com \
    --to=eddyz87@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=chantr4@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=quentin@isovalent.com \
    --cc=sdf@google.com \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox