BPF List
 help / color / mirror / Atom feed
From: Yonghong Song <yhs@fb.com>
To: Andrei Matei <andreimatei1@gmail.com>, <bpf@vger.kernel.org>
Cc: <andrii@kernel.org>
Subject: Re: [PATCH bpf-next] selftest/bpf: fix compilation on clang 11
Date: Tue, 24 Nov 2020 22:28:44 -0800	[thread overview]
Message-ID: <a97c41f4-04b6-1ce2-9fe4-472e4ee6205a@fb.com> (raw)
In-Reply-To: <20201125035255.17970-1-andreimatei1@gmail.com>



On 11/24/20 7:52 PM, Andrei Matei wrote:
> Before this patch, profiler.inc.h wouldn't compile with clang-11 (before
> the __builtin_preserve_enum_value LLVM builtin was introduced in
> https://reviews.llvm.org/D83242 ).
> Another test that uses this builtin (test_core_enumval) is conditionally
> skipped if the compiler is too old. In that spirit, this patch inhibits
> part of populate_cgroup_info(), which needs this CO-RE builtin. The
> selftests build again on clang-11.  The affected test (the profiler
> test) doesn't pass on clang-11 because it's missing
> https://reviews.llvm.org/D85570 , but at least the test suite as a whole
> compiles. The test's expected failure is already called out in the
> README.
> 
> Signed-off-by: Andrei Matei <andreimatei1@gmail.com>

Thanks for the fix! This change won't impact correctness as
profiler.c mostly to test verifier.

Acked-by: Yonghong Song <yhs@fb.com>

  reply	other threads:[~2020-11-25  6:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25  3:52 [PATCH bpf-next] selftest/bpf: fix compilation on clang 11 Andrei Matei
2020-11-25  6:28 ` Yonghong Song [this message]
2020-11-25 20:20 ` Florian Lehner
2020-11-25 23:37 ` Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a97c41f4-04b6-1ce2-9fe4-472e4ee6205a@fb.com \
    --to=yhs@fb.com \
    --cc=andreimatei1@gmail.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox