From: Ihor Solodrai <ihor.solodrai@linux.dev>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Eduard Zingerman <eddyz87@gmail.com>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Quentin Monnet <qmo@kernel.org>
Cc: bpf@vger.kernel.org, Alan Maguire <alan.maguire@oracle.com>,
Cupertino Miranda <cupertino.miranda@oracle.com>,
David Faust <david.faust@oracle.com>,
Ian Rogers <irogers@google.com>,
"Jose E . Marchesi" <jose.marchesi@oracle.com>,
Vineet Gupta <vineet.gupta@linux.dev>,
Yonghong Song <yonghong.song@linux.dev>
Subject: Re: [PATCH bpf-next v1 5/8] bpftool: Emit __bpf_core_pso on verifier-rewritten context types
Date: Fri, 16 Oct 2026 10:44:43 -0700 [thread overview]
Message-ID: <a99c19a5-c5ef-4bf5-91f7-8fae78858db9@linux.dev> (raw)
In-Reply-To: <DM6DTIR83Q2M.1GEPF95MFWXY5@gmail.com>
On 2026-10-16 8:53 a.m., Alexei Starovoitov wrote:
> On Thu, Oct 15, 2026 at 10:49 PM Ihor Solodrai <ihor.solodrai@linux.dev> wrote:
>> When PSO lands, people might run into this as soon as they use new
>> bpftool to generate vmlinux.h, and the failure is very loud.
>
> fwiw calico does
> if (bpf_core_field_exists(skb->gso_size)) {
> on __sk_buff in skb_is_gso().
> It includes linux/bpf.h and not vmlinux.h, so it's not affected,
> but the pattern is out there.
>
>> Yeah, the __bpf_core_<foo> might not be the best name.
>> I like btf_relocatable for PAI, should this be btf_unrelocatable?..
>
> A struct without any attribute is not relocatable either.
> iirc Eduard used __bpf_ctx earlier.
> It's more of 'hey compiler dont mess with field offset'.
> 'bpf_static_offset'? 'bpf_fixed_offset' ?
From these bpf_static_offset makes most sense to me, because it matches
the compiler attribute name (preserve_static_offset).
next prev parent reply other threads:[~2026-10-16 17:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 0:00 [PATCH bpf-next v1 0/8] bpftool: Per-record CO-RE attributes in the C dump Ihor Solodrai
2026-10-16 0:00 ` [PATCH bpf-next v1 1/8] bpftool: Dump C from a detached BTF copy Ihor Solodrai
2026-10-16 1:18 ` Alexei Starovoitov
2026-10-16 9:44 ` Alan Maguire
2026-10-16 17:40 ` Ihor Solodrai
2026-10-16 9:25 ` Alan Maguire
2026-10-16 17:41 ` Ihor Solodrai
2026-10-16 0:00 ` [PATCH bpf-next v1 2/8] selftests/bpf: Cover unknown BTF header-extension bytes in btf dump Ihor Solodrai
2026-10-16 0:00 ` [PATCH bpf-next v1 3/8] bpftool: Apply __bpf_core_pai per record on BTF dump Ihor Solodrai
2026-10-16 0:39 ` bot+bpf-ci
2026-10-16 1:17 ` Alexei Starovoitov
2026-10-16 0:00 ` [PATCH bpf-next v1 4/8] bpftool: Skip __bpf_core_pai on verifier-rewritten context types Ihor Solodrai
2026-10-16 0:00 ` [PATCH bpf-next v1 5/8] bpftool: Emit __bpf_core_pso " Ihor Solodrai
2026-10-16 1:27 ` Alexei Starovoitov
2026-10-16 5:49 ` Ihor Solodrai
2026-10-16 15:53 ` Alexei Starovoitov
2026-10-16 17:44 ` Ihor Solodrai [this message]
2026-10-16 0:00 ` [PATCH bpf-next v1 6/8] selftests/bpf: Cover record attributes in bpftool BTF dumps Ihor Solodrai
2026-10-16 0:00 ` [PATCH bpf-next v1 7/8] selftests/bpf: Cover context and socket accesses through vmlinux.h Ihor Solodrai
2026-10-16 0:00 ` [PATCH bpf-next v1 8/8] bpftool: Document __bpf_core_pai and __bpf_core_pso Ihor Solodrai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a99c19a5-c5ef-4bf5-91f7-8fae78858db9@linux.dev \
--to=ihor.solodrai@linux.dev \
--cc=alan.maguire@oracle.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cupertino.miranda@oracle.com \
--cc=daniel@iogearbox.net \
--cc=david.faust@oracle.com \
--cc=eddyz87@gmail.com \
--cc=irogers@google.com \
--cc=jose.marchesi@oracle.com \
--cc=memxor@gmail.com \
--cc=qmo@kernel.org \
--cc=vineet.gupta@linux.dev \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox