From: Andrea Righi <arighi@nvidia.com>
To: Honglei Wang <jameshongleiwang@126.com>
Cc: tj@kernel.org, void@manifault.com, changwoo@igalia.com,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com, joshdon@google.com, brho@google.com,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH v2 0/2] rename var for slice refill event and add helper
Date: Fri, 18 Apr 2025 07:53:14 +0200 [thread overview]
Message-ID: <aAHoyhfSV1ZUjwDv@gpd3> (raw)
In-Reply-To: <20250418032603.61803-1-jameshongleiwang@126.com>
On Fri, Apr 18, 2025 at 11:26:01AM +0800, Honglei Wang wrote:
> SCX_EV_ENQ_SLICE_DFL gives the impression that the event only occurs
> when the tasks were enqueued, which seems not accurate. So rename the
> variable to SCX_EV_REFILL_SLICE_DFL.
>
> The slice refilling with default slice always come with event
> statistics together, add a helper routine to make it cleaner.
>
> Changes in v2:
> Refine the comments base on Andrea's suggestion.
Looks good, thanks!
Acked-by: Andrea Righi <arighi@nvidia.com>
-Andrea
next prev parent reply other threads:[~2025-04-18 5:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 3:26 [PATCH v2 0/2] rename var for slice refill event and add helper Honglei Wang
2025-04-18 3:26 ` [PATCH v2 1/2] sched_ext: change the variable name for slice refill event Honglei Wang
2025-04-18 3:26 ` [PATCH v2 2/2] sched_ext: add helper for refill task with default slice Honglei Wang
2025-04-18 3:55 ` [PATCH v2 0/2] rename var for slice refill event and add helper Changwoo Min
2025-04-18 5:53 ` Andrea Righi [this message]
2025-04-19 3:28 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAHoyhfSV1ZUjwDv@gpd3 \
--to=arighi@nvidia.com \
--cc=bpf@vger.kernel.org \
--cc=brho@google.com \
--cc=bsegall@google.com \
--cc=changwoo@igalia.com \
--cc=dietmar.eggemann@arm.com \
--cc=jameshongleiwang@126.com \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=void@manifault.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox