Re: [PATCH v5 bpf-next 11/15] bpf: disasm: add support for BPF_JMP|BPF_JA|BPF_X

[Anton Protopopov <a.s.protopopov@gmail.com>]

On 25/10/01 05:18PM, Eduard Zingerman wrote:
> On Tue, 2025-09-30 at 12:51 +0000, Anton Protopopov wrote:
> 
> [...]
> 
> > diff --git a/kernel/bpf/disasm.c b/kernel/bpf/disasm.c
> > index 20883c6b1546..4a1ecc6f7582 100644
> > --- a/kernel/bpf/disasm.c
> > +++ b/kernel/bpf/disasm.c
> > @@ -183,6 +183,13 @@ static inline bool is_mov_percpu_addr(const struct bpf_insn *insn)
> >  	return insn->code == (BPF_ALU64 | BPF_MOV | BPF_X) && insn->off == BPF_ADDR_PERCPU;
> >  }
> >  
> > +static void print_bpf_ja_indirect(bpf_insn_print_t verbose,
> > +				  void *private_data,
> > +				  const struct bpf_insn *insn)
> > +{
> > +	verbose(private_data, "(%02x) gotox r%d\n", insn->code, insn->dst_reg);
> > +}
> > +
> 
> Nit: there is no need for this to be a separate function,
>      can be a direct verbose call, like for any other instruction.

Thanks, removed. (The function was part of the statick keys patch
to print all ja-related insns.)

> >  void print_bpf_insn(const struct bpf_insn_cbs *cbs,
> >  		    const struct bpf_insn *insn,
> >  		    bool allow_ptr_leaks)
> > @@ -358,6 +365,8 @@ void print_bpf_insn(const struct bpf_insn_cbs *cbs,
> >  		} else if (insn->code == (BPF_JMP | BPF_JA)) {
> >  			verbose(cbs->private_data, "(%02x) goto pc%+d\n",
> >  				insn->code, insn->off);
> > +		} else if (insn->code == (BPF_JMP | BPF_JA | BPF_X)) {
> > +			print_bpf_ja_indirect(verbose, cbs->private_data, insn);
> >  		} else if (insn->code == (BPF_JMP | BPF_JCOND) &&
> >  			   insn->src_reg == BPF_MAY_GOTO) {
> >  			verbose(cbs->private_data, "(%02x) may_goto pc%+d\n",