From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DD452080C8 for ; Fri, 26 Sep 2025 04:20:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758860462; cv=none; b=mUPwKZQAKvVqq465gYnBm9yaC2Fn2MDhDYGYulvIBgGnnVl37ESwmQL4I7zKJaeBIT/gd0mV8IbSsleOYBALlPFIxzJIl86YYnhZRIjRz+G+Oco3CEKlyzHvA9gnTnc0qH9/T8vUEQ1N1Qir6SGVF+7BwJKXg60fGo5aAhk7qYg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758860462; c=relaxed/simple; bh=eR95EyaDEJj3N3ApGR3XQ1Y0G40+I20qy/wBgSvIZVM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rzc9CODlwoJxUuWnts4bBm30fYAqoL///KAxCkwjp5VG6eeSuz/kAgp2gz4dQQ+/CqKOFcJ4DKrp6HpMYzPBvbd9WlmVvmC6+CMu2PtFvFrkz0obhARTghta8se/o1/+ZmF18NVX6MSlzRgQRDs8w0k/JzVOzHboxtIkeUmzMHk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=coQT9YQ3; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="coQT9YQ3" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-b5506b28c98so1183021a12.1 for ; Thu, 25 Sep 2025 21:20:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758860459; x=1759465259; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sXTN/i9kgbuo8arMMY6rYBFHJ+Czs9wquc3zmOOkLw8=; b=coQT9YQ3k+xJUbS9FiFI+MMMuIRUv8/Et/C9hobAqD1GE3r8mno1FYUp8QpSp/hSH8 NjS4T35WTVDS6sw1L3R6Wy2/XCRg4XupWZk47f2fytX20iD5ugGwDd9BiaJeQwyWfSgC p5mj5EQIWJr/zKD5gJ2fPlQ+8JibJoUuHRJBgxSIdQRW9n5VLSc/mTvdSmGU040OKK2g rLqcdxXiKPNbMtONZvTrhHiiX8nb9WefYLKaVkAZUXxBlqJyeHJx5Fs/PN/Jrf+R/U+k mcCWfhHW9R0xN3uywNNx1+4JcvJduvi61Vn69Dl0RZl+wsYqyLLX/wtjWI90vvTVm00Y 4y2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758860459; x=1759465259; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sXTN/i9kgbuo8arMMY6rYBFHJ+Czs9wquc3zmOOkLw8=; b=NO899RiCoYTu7oKMYqaKn6aT1K148FN7dPe8W6FjDAfBkFmVMsfVjq84uhBkBW03C3 Ag1dxoug0WRg7QKAzmSH6X/zrhJFubOE2zEnx4bCz7TzO0XW4xEXe0rx+t0adAeX/lMA GShSTpckyPzopVd2dl+FZuOWyfWXd1j2bmd98NMBXwItG5PgeOOKVtEi54u306vsKX50 Hbh4wT4kS94w65yir5MjExoB+P7V6pck8zaMX5+jxP+IoP9BvFNNrGSYTrqwqGyLwhCg 1YWMq3XySONhf+oj+XbkKtmlbu/YwqIa5TMxI8HgmMrqzfP14C8nBdJ5NmUiPZxtU+vM 82Xg== X-Forwarded-Encrypted: i=1; AJvYcCUfVCTvOWdXrkNy5+d7ujCGVTY9QBzbfM/dZkbpdOV3FlLlmr5VZN+OiN2bjZB4dLS9ZXI=@vger.kernel.org X-Gm-Message-State: AOJu0YyuAiVSNuC9OTZBRA/5wisWmmUHXIll0Qxf2wF/cTTfYcscVLQ2 YQYUQc6O5jo4s9uckjbjeKUN71I27MfprhNrEz81T/UfBWRJM2mJA/g= X-Gm-Gg: ASbGnctnsCXgHn0jWzeNs6MM8GxZpBqVlXKgHQ2x0GVEudraFVtoMNjjlTfEszFUqp1 PR1oT3LRRde6M4pknAPvRr3piXtuBWG1SES6CH03rkMUS+ED9nmI6E6LBvDXERL+FWnwRccVnAB hMxQupFRFfrvqWfd0KRuDQyjAMfKHFara4VW/DJqxOPaZDpyyaXjHm7KweYipDMJk/iaFmrQgP3 leazcG7gENyyEj8z0IT48Iq2EC0Y7Xp5QBhzTa1mldVegiq9qfd6egbwnG5TI06a+5/gYnRhHmY awodZMuC3aCnYhMk0KZ15CZbljVbn5QU3bFc3rG1o2J61YK2GzxcfHDYDUvMLGQbD+zzy5TWb85 dDwHpR6osdoKiHYF6gsSuc1Pa/18IcT+s/rEKT1Bdl6KVwM7pSttxGac+6MNvIcaynHGb1qXHKl zJrfEcqI9YSP0GUN7/hC0O8wT26aK24eKoTtmjgB58DpOGuRTaHTgB0gpSyQMrSE1GjEvoyyoJ4 Krh X-Google-Smtp-Source: AGHT+IGHgag9Cvz1ZRdx/09/Op9JnLEt1h9vJf23LW70kwNFj3KdcgxMtOnNN6rMFnuWqeU3odbSTw== X-Received: by 2002:a17:902:cccf:b0:252:50ad:4e6f with SMTP id d9443c01a7336-27ed4adad59mr69191975ad.54.1758860458545; Thu, 25 Sep 2025 21:20:58 -0700 (PDT) Received: from localhost (c-73-158-218-242.hsd1.ca.comcast.net. [73.158.218.242]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-27ed6700ccdsm40125045ad.37.2025.09.25.21.20.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Sep 2025 21:20:58 -0700 (PDT) Date: Thu, 25 Sep 2025 21:20:57 -0700 From: Stanislav Fomichev To: Lorenzo Bianconi Cc: Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Andrew Lunn , Tony Nguyen , Przemek Kitszel , Alexander Lobakin , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Shuah Khan , Maciej Fijalkowski , netdev@vger.kernel.org, bpf@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH RFC bpf-next v2 1/5] netlink: specs: Add XDP RX checksum capability to XDP metadata specs Message-ID: References: <20250925-bpf-xdp-meta-rxcksum-v2-0-6b3fe987ce91@kernel.org> <20250925-bpf-xdp-meta-rxcksum-v2-1-6b3fe987ce91@kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250925-bpf-xdp-meta-rxcksum-v2-1-6b3fe987ce91@kernel.org> On 09/25, Lorenzo Bianconi wrote: > Introduce XDP RX checksum capability to XDP metadata specs. XDP RX > checksum will be use by devices capable of exposing receive checksum > result via bpf_xdp_metadata_rx_checksum(). > Moreover, introduce xmo_rx_checksum netdev callback in order allow the > eBPF program bounded to the device to retrieve the RX checksum result > computed by the hw NIC. > > Signed-off-by: Lorenzo Bianconi > --- > Documentation/netlink/specs/netdev.yaml | 5 +++++ > include/net/xdp.h | 14 ++++++++++++++ > net/core/xdp.c | 29 +++++++++++++++++++++++++++++ > 3 files changed, 48 insertions(+) > > diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlink/specs/netdev.yaml > index e00d3fa1c152d7165e9485d6d383a2cc9cef7cfd..00699bf4a7fdb67c6b9ee3548098b0c933fd39a4 100644 > --- a/Documentation/netlink/specs/netdev.yaml > +++ b/Documentation/netlink/specs/netdev.yaml > @@ -61,6 +61,11 @@ definitions: > doc: | > Device is capable of exposing receive packet VLAN tag via > bpf_xdp_metadata_rx_vlan_tag(). > + - > + name: checksum > + doc: | > + Device is capable of exposing receive checksum result via > + bpf_xdp_metadata_rx_checksum(). > - > type: flags > name: xsk-flags > diff --git a/include/net/xdp.h b/include/net/xdp.h > index aa742f413c358575396530879af4570dc3fc18de..9ab9ac10ae2074b70618a9d4f32544d8b9a30b63 100644 > --- a/include/net/xdp.h > +++ b/include/net/xdp.h > @@ -586,6 +586,10 @@ void xdp_attachment_setup(struct xdp_attachment_info *info, > NETDEV_XDP_RX_METADATA_VLAN_TAG, \ > bpf_xdp_metadata_rx_vlan_tag, \ > xmo_rx_vlan_tag) \ > + XDP_METADATA_KFUNC(XDP_METADATA_KFUNC_RX_CHECKSUM, \ > + NETDEV_XDP_RX_METADATA_CHECKSUM, \ > + bpf_xdp_metadata_rx_checksum, \ > + xmo_rx_checksum) > > enum xdp_rx_metadata { > #define XDP_METADATA_KFUNC(name, _, __, ___) name, > @@ -643,12 +647,22 @@ enum xdp_rss_hash_type { > XDP_RSS_TYPE_L4_IPV6_SCTP_EX = XDP_RSS_TYPE_L4_IPV6_SCTP | XDP_RSS_L3_DYNHDR, > }; > > +enum xdp_checksum { > + XDP_CHECKSUM_NONE = CHECKSUM_NONE, > + XDP_CHECKSUM_UNNECESSARY = CHECKSUM_UNNECESSARY, > + XDP_CHECKSUM_COMPLETE = CHECKSUM_COMPLETE, > + XDP_CHECKSUM_PARTIAL = CHECKSUM_PARTIAL, > +}; Btw, might be worth mentioning, awhile ago we had settled on a smaller set of exposed types: https://lore.kernel.org/netdev/20230811161509.19722-13-larysa.zaremba@intel.com/ Maybe go through the previous postings and check if the arguments are still relevant? (or explain why we want more checksum now)