bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anton Protopopov <a.s.protopopov@gmail.com>
To: Eduard Zingerman <eddyz87@gmail.com>
Cc: bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Anton Protopopov <aspsk@isovalent.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Quentin Monnet <qmo@kernel.org>,
	Yonghong Song <yonghong.song@linux.dev>
Subject: Re: [PATCH v6 bpf-next 12/17] bpf, docs: do not state that indirect jumps are not supported
Date: Tue, 21 Oct 2025 19:32:18 +0000	[thread overview]
Message-ID: <aPffwozAdFGGgyc3@mail.gmail.com> (raw)
In-Reply-To: <83225612f07f1d0f2f488efaee9c075b44e8cc03.camel@gmail.com>

On 25/10/21 12:15PM, Eduard Zingerman wrote:
> On Sun, 2025-10-19 at 20:21 +0000, Anton Protopopov wrote:
> > The linux-notes.rst states that indirect jump instruction "is not
> > currently supported by the verifier". Remove this part as outdated.
> > 
> > Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
> > ---
> >  Documentation/bpf/linux-notes.rst | 8 --------
> >  1 file changed, 8 deletions(-)
> > 
> > diff --git a/Documentation/bpf/linux-notes.rst b/Documentation/bpf/linux-notes.rst
> > index 00d2693de025..64ac146a926f 100644
> > --- a/Documentation/bpf/linux-notes.rst
> > +++ b/Documentation/bpf/linux-notes.rst
> > @@ -12,14 +12,6 @@ Byte swap instructions
> >  
> >  ``BPF_FROM_LE`` and ``BPF_FROM_BE`` exist as aliases for ``BPF_TO_LE`` and ``BPF_TO_BE`` respectively.
> >  
> > -Jump instructions
> > -=================
> > -
> > -``BPF_CALL | BPF_X | BPF_JMP`` (0x8d), where the helper function
> > -integer would be read from a specified register, is not currently supported
> > -by the verifier.  Any programs with this instruction will fail to load
> > -until such support is added.
> > -
> >  Maps
> >  ====
> >  
> 
> Nit: bpf/standardization/instruction-set.rst needs an update,
>      we don't have anything about `JA|X|JMP` in the "Jump instructions"
>      section there.

Ah yes, thanks.

Also, there is a limitation listed in the llvm doc that -O0
can't be used due to absence of indirect jumps. I wonder if
there should be more limitations introduced since the doc
was written. (I've tried, briefly, to compile selftests with -O0,
but this fails for other reasons, and I didn't have time to dig
into this.)

  reply	other threads:[~2025-10-21 19:25 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-19 20:21 [PATCH v6 bpf-next 00/17] BPF indirect jumps Anton Protopopov
2025-10-19 20:21 ` [PATCH v6 bpf-next 01/17] bpf: fix the return value of push_stack Anton Protopopov
2025-10-19 20:21 ` [PATCH v6 bpf-next 02/17] bpf: save the start of functions in bpf_prog_aux Anton Protopopov
2025-10-19 20:21 ` [PATCH v6 bpf-next 03/17] bpf: generalize and export map_get_next_key for arrays Anton Protopopov
2025-10-19 20:21 ` [PATCH v6 bpf-next 04/17] bpf, x86: add new map type: instructions array Anton Protopopov
2025-10-21 17:49   ` Alexei Starovoitov
2025-10-21 18:32     ` Anton Protopopov
2025-10-21 23:26   ` Eduard Zingerman
2025-10-24 12:12     ` Anton Protopopov
2025-10-19 20:21 ` [PATCH v6 bpf-next 05/17] selftests/bpf: add selftests for new insn_array map Anton Protopopov
2025-10-21 23:51   ` Eduard Zingerman
2025-10-22 13:44     ` Anton Protopopov
2025-10-22 13:55       ` Eduard Zingerman
2025-10-22 14:06         ` Anton Protopopov
2025-10-22 14:03           ` Eduard Zingerman
2025-10-22 14:13             ` Anton Protopopov
2025-10-22 17:00             ` Eduard Zingerman
2025-10-19 20:21 ` [PATCH v6 bpf-next 06/17] bpf: support instructions arrays with constants blinding Anton Protopopov
2025-10-19 20:21 ` [PATCH v6 bpf-next 07/17] selftests/bpf: test instructions arrays with blinding Anton Protopopov
2025-10-19 20:21 ` [PATCH v6 bpf-next 08/17] bpf, x86: allow indirect jumps to r8...r15 Anton Protopopov
2025-10-20  8:38   ` Anton Protopopov
2025-10-19 20:21 ` [PATCH v6 bpf-next 09/17] bpf: make bpf_insn_successors to return a pointer Anton Protopopov
2025-10-19 20:21 ` [PATCH v6 bpf-next 10/17] bpf, x86: add support for indirect jumps Anton Protopopov
2025-10-20  7:23   ` Anton Protopopov
2025-10-21 21:17   ` Eduard Zingerman
2025-10-22  6:51     ` Anton Protopopov
2025-10-22  6:53       ` Eduard Zingerman
2025-10-19 20:21 ` [PATCH v6 bpf-next 11/17] bpf: disasm: add support for BPF_JMP|BPF_JA|BPF_X Anton Protopopov
2025-10-21 21:19   ` Eduard Zingerman
2025-10-19 20:21 ` [PATCH v6 bpf-next 12/17] bpf, docs: do not state that indirect jumps are not supported Anton Protopopov
2025-10-21 19:15   ` Eduard Zingerman
2025-10-21 19:32     ` Anton Protopopov [this message]
2025-10-21 19:36       ` Eduard Zingerman
2025-10-21 19:50         ` Anton Protopopov
2025-10-21 20:17           ` Eduard Zingerman
2025-10-19 20:21 ` [PATCH v6 bpf-next 13/17] libbpf: fix formatting of bpf_object__append_subprog_code Anton Protopopov
2025-10-19 20:21 ` [PATCH v6 bpf-next 14/17] libbpf: support llvm-generated indirect jumps Anton Protopopov
2025-10-21 22:18   ` Eduard Zingerman
2025-10-21 22:45     ` Eduard Zingerman
2025-10-24 12:52     ` Anton Protopopov
2025-10-25 17:39       ` Anton Protopopov
2025-10-19 20:21 ` [PATCH v6 bpf-next 15/17] bpftool: Recognize insn_array map type Anton Protopopov
2025-10-19 20:21 ` [PATCH v6 bpf-next 16/17] selftests/bpf: add new verifier_gotox test Anton Protopopov
2025-10-21 22:42   ` Eduard Zingerman
2025-10-24 11:40     ` Anton Protopopov
2025-10-26 12:34       ` Anton Protopopov
2025-10-27 23:11         ` Eduard Zingerman
2025-10-28 12:06           ` Anton Protopopov
2025-10-19 20:21 ` [PATCH v6 bpf-next 17/17] selftests/bpf: add C-level selftests for indirect jumps Anton Protopopov
2025-10-22  0:27   ` Eduard Zingerman
2025-10-22 13:34     ` Anton Protopopov
2025-10-25 17:41       ` Anton Protopopov
2025-10-21 18:30 ` [PATCH v6 bpf-next 00/17] BPF " patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPffwozAdFGGgyc3@mail.gmail.com \
    --to=a.s.protopopov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=aspsk@isovalent.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=qmo@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).