From: Dominique Martinet <asmadeus@codewreck.org>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Xing Guo <higuoxing@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>,
Alexei Starovoitov <ast@kernel.org>, bpf <bpf@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>, Jiri Olsa <olsajiri@gmail.com>,
sveiss@meta.com, Linux-Fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: strace log before the fix, with fsync fix and with fclose fix.
Date: Wed, 22 Oct 2025 07:14:46 +0900 [thread overview]
Message-ID: <aPgF1u8OaMkWvWK2@codewreck.org> (raw)
In-Reply-To: <CAEf4BzZbCE4tLoDZyUf_aASpgAGFj75QMfSXX4a4dLYixnOiLg@mail.gmail.com>
Andrii Nakryiko wrote on Mon, Oct 20, 2025 at 01:12:16PM -0700:
> So unclear, which is why it would be nice for FS folks to double
> check. It's certainly a change in behavior, it used to work reliably
> before. [0] is the source code of the test (and note that we now added
> fsync(), without it the test is now broken).
It's a 9p bug, sorry.
tentative fix:
https://lkml.kernel.org/r/20251022-mmap-regression-v1-1-980365ee524e@codewreck.org
other thread with repro:
https://lkml.kernel.org/r/CAHzjS_u_SYdt5=2gYO_dxzMKXzGMt-TfdE_ueowg-Hq5tRCAiw@mail.gmail.com
I'll send the fix to Linus once someone can confirm this works for this
usecase as well (and try to improve our testing a bit... maybe just run
the bpf test suite for starters)
--
Dominique Martinet | Asmadeus
next prev parent reply other threads:[~2025-10-21 22:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 8:03 [PATCH] selftests: arg_parsing: Ensure data is flushed to disk before reading Xing Guo
2025-10-14 12:39 ` Jiri Olsa
2025-10-14 20:53 ` Andrii Nakryiko
2025-10-15 2:43 ` [PATCH v2] " Xing Guo
2025-10-15 2:45 ` Alexei Starovoitov
2025-10-15 2:50 ` Xing Guo
2025-10-15 16:10 ` patchwork-bot+netdevbpf
2025-10-15 16:20 ` Andrii Nakryiko
2025-10-16 2:28 ` [PATCH v3] " Xing Guo
2025-10-16 2:32 ` [PATCH v2] " Xing Guo
2025-10-16 2:37 ` [PATCH bpf v4] " Xing Guo
2025-10-16 3:19 ` [PATCH bpf v5] " Xing Guo
2025-10-16 3:53 ` [PATCH bpf v6] " Xing Guo
2025-10-16 16:36 ` Andrii Nakryiko
2025-10-20 8:59 ` strace log before the fix, with fsync fix and with fclose fix Xing Guo
2025-10-20 16:28 ` Alexei Starovoitov
2025-10-20 20:12 ` Andrii Nakryiko
2025-10-21 22:14 ` Dominique Martinet [this message]
2025-10-16 16:40 ` [PATCH bpf v6] selftests: arg_parsing: Ensure data is flushed to disk before reading patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPgF1u8OaMkWvWK2@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=higuoxing@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=olsajiri@gmail.com \
--cc=sveiss@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox