Re: [PATCH v6 bpf-next 05/17] selftests/bpf: add selftests for new insn_array map

[Anton Protopopov <a.s.protopopov@gmail.com>]

On 25/10/22 07:03AM, Eduard Zingerman wrote:
> On Wed, 2025-10-22 at 14:06 +0000, Anton Protopopov wrote:
> 
> [...]
> 
> > > > > > diff --git a/tools/testing/selftests/bpf/prog_tests/bpf_insn_array.c b/tools/testing/selftests/bpf/prog_tests/bpf_insn_array.c
> > > > > > new file mode 100644
> > > > > > index 000000000000..a4304ef5be13
> > > > > > --- /dev/null
> > > > > > +++ b/tools/testing/selftests/bpf/prog_tests/bpf_insn_array.c
> > > > > 
> > > > > [...]
> > > > > 
> > > > > > +static void check_bpf_no_lookup(void)
> > > > > 
> > > > > This one can be moved to prog_tests/bpf_insn_array.c, I think.
> > > > 
> > > > A typo? (This is a patch for the prog_tests/bpf_insn_array.c)
> > > 
> > > Yes, I mean progs/verifier_gotox.c, the one with inline assembly.
> > 
> > I think it should stay here. There will be other usages of the
> > instruction array, and neither should allow operations on it from
> > a BPF prog (indirect calls, static keys).
> 
> It will be functionally identical and like 3x-4x time shorter in that file.

Ok, I see. I will either move it there, or add another
verifier_insn_array (if I see how to convert/create more "insn array
level" tests like this).