From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Alan Maguire <alan.maguire@oracle.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Ihor Solodrai <ihor.solodrai@linux.dev>,
dwarves <dwarves@vger.kernel.org>, Eduard <eddyz87@gmail.com>,
bpf <bpf@vger.kernel.org>, Andrii Nakryiko <andrii@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Kernel Team <kernel-team@meta.com>
Subject: Re: [PATCH dwarves v4 0/3] btf_encoder: refactor emission of BTF funcs
Date: Fri, 14 Nov 2025 17:52:36 -0300 [thread overview]
Message-ID: <aReWlPqSGWnj8sPf@x1> (raw)
In-Reply-To: <cf503462-6616-4cdc-ae63-b126b28ae66a@oracle.com>
On Fri, Nov 14, 2025 at 03:40:36PM +0000, Alan Maguire wrote:
> On 14/11/2025 02:10, Arnaldo Carvalho de Melo wrote:
> > On Thu, Nov 13, 2025 at 09:20:44AM -0800, Alexei Starovoitov wrote:
> >> On Thu, Nov 13, 2025 at 8:37 AM Alan Maguire <alan.maguire@oracle.com> wrote:
> >>>
> >>> On 06/11/2025 01:28, Ihor Solodrai wrote:
> >>>> This series refactors a few functions that handle how BTF functions
> >>>> are emitted.
> >>>>
> >>>> v3->v4: Error handling nit from Eduard
> >>>> v2->v3: Add patch removing encoder from btf_encoder_func_state
> >>>> v3: https://lore.kernel.org/dwarves/20251105185926.296539-1-ihor.solodrai@linux.dev/
> >>>> v2: https://lore.kernel.org/dwarves/20251104233532.196287-1-ihor.solodrai@linux.dev/
> >>>> v1: https://lore.kernel.org/dwarves/20251029190249.3323752-2-ihor.solodrai@linux.dev/
> >>> series applied to the next branch of
> >>> https://git.kernel.org/pub/scm/devel/pahole/pahole.git/
> >> Same rant as before...
> >> Can we please keep it normal with all changes going to master ?
> >> This 'next' branch confused people in the past.
> >
> > I think the problem before was that it sat there for far too long.
> >
> > I see value in it staying there for a short period for some eventual
> > rebase and for some CI thing, to avoid polluting, think of it as some
> > topic branch on the way to master.
Somehow my reply via the smartphone didn't seem to have made to the
list...
> Yeah, I think if we can augment CI to cover more we can narrow this
> window, aiming for zero as the test coverage improves.
So the 'next' is an artifact for CI usage, i.e. if we just don't
announce that it was merged, do it for the CI sake and then when it runs
and don't detect any problem we go ahead and merge into master and
announce that it was merged, nothing of this drama would take place.
The best thing going forward I think is to have AI reviewing just like
with the BPF patches, having the patches, once posted to the list by the
contributors, trigger the CI, that amongst other things do the AI
reviewing, if all is ok, maintainers get some nudge that AI bot is ok,
etc and merge it in master, annouce publicly, yadda, yadda.
> The other thing we should think about maybe is syncing
> github.com/acmel/dwarves with pahole.git as many people are pulling
> from github.
> Should we discourage using the github repo, or just find a way to
> mirror pahole.git automatically? Thanks!
I think we should have a https://github.com/pahole/ area that is
administered by the pahole maintainer(s), just like there are:
https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools.git/
https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/
For the project (current merge window, next merge window) and my
personal, previously canonical, perf and other kernel work repo:
https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/
:-)
- Arnaldo
next prev parent reply other threads:[~2025-11-14 20:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 1:28 [PATCH dwarves v4 0/3] btf_encoder: refactor emission of BTF funcs Ihor Solodrai
2025-11-06 1:28 ` [PATCH dwarves v4 1/3] btf_encoder: Remove encoder pointer from btf_encoder_func_state Ihor Solodrai
2025-11-06 1:28 ` [PATCH dwarves v4 2/3] btf_encoder: Refactor btf_encoder__add_func_proto Ihor Solodrai
2025-11-06 1:28 ` [PATCH dwarves v4 3/3] btf_encoder: Factor out BPF kfunc emission Ihor Solodrai
2025-11-13 16:36 ` [PATCH dwarves v4 0/3] btf_encoder: refactor emission of BTF funcs Alan Maguire
2025-11-13 17:20 ` Alexei Starovoitov
2025-11-14 2:10 ` Arnaldo Carvalho de Melo
2025-11-14 2:14 ` Alexei Starovoitov
2025-11-14 15:40 ` Alan Maguire
2025-11-14 16:27 ` Arnaldo Melo
2025-11-14 20:52 ` Arnaldo Carvalho de Melo [this message]
2025-11-14 20:54 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aReWlPqSGWnj8sPf@x1 \
--to=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dwarves@vger.kernel.org \
--cc=eddyz87@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=kernel-team@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).