public inbox for bpf@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Emil Tsalapatis <emil@etsalapatis.com>
Cc: Zhao Mengmeng <zhaomzhao@126.com>,
	void@manifault.com, arighi@nvidia.com, changwoo@igalia.com,
	nathan@kernel.org, nick.desaulniers+lkml@gmail.com,
	morbo@google.com, justinstitt@google.com,
	sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org,
	bpf@vger.kernel.org, llvm@lists.linux.dev,
	zhaomengmeng@kylinos.cn
Subject: Re: [PATCH v2 2/2] tools/sched_ext: scx_sdt: Fix BPF verifier rejection on older LLVMs
Date: Mon, 9 Mar 2026 06:44:56 -1000	[thread overview]
Message-ID: <aa75CBAMNtK-L-ew@slm.duckdns.org> (raw)
In-Reply-To: <DGYECIPVC266.25320R7256YJT@etsalapatis.com>

On Mon, Mar 09, 2026 at 12:36:40PM -0400, Emil Tsalapatis wrote:
> On the other hand, maybe the extra compatibility is worth re-adding 
> cast_kern/cast_user to the code. I am slightly in favor of keeping it
> as-is to avoid churn, but can easily see why we'd go the other way.
> 
> @htejun WDYT?

Let's leave it as-is. The main purpose is to serve as an example for future
arena users. The benefit of keeping it simple trumps over supporting older
compilers.

thanks.

-- 
tejun

  parent reply	other threads:[~2026-03-09 16:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09  2:28 [PATCH v2 0/2] sched_ext cleanup and toolchain compatibility fixes Zhao Mengmeng
2026-03-09  2:28 ` [PATCH v2 1/2] sched_ext: remove SCX_OPS_HAS_CGROUP_WEIGHT Zhao Mengmeng
2026-03-09  2:28 ` [PATCH v2 2/2] tools/sched_ext: scx_sdt: Fix BPF verifier rejection on older LLVMs Zhao Mengmeng
2026-03-09 16:36   ` Emil Tsalapatis
2026-03-09 16:43     ` Alexei Starovoitov
2026-03-09 16:44     ` Tejun Heo [this message]
2026-03-09 16:58       ` Zhao mengmeng
2026-03-09 19:49 ` [PATCH v2 0/2] sched_ext: cleanup and toolchain compatibility fixes Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa75CBAMNtK-L-ew@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=arighi@nvidia.com \
    --cc=bpf@vger.kernel.org \
    --cc=changwoo@igalia.com \
    --cc=emil@etsalapatis.com \
    --cc=justinstitt@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=sched-ext@lists.linux.dev \
    --cc=void@manifault.com \
    --cc=zhaomengmeng@kylinos.cn \
    --cc=zhaomzhao@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox