BPF List
 help / color / mirror / Atom feed
From: Yonghong Song <yhs@fb.com>
To: <bpf@vger.kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>, <kernel-team@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	Lorenz Bauer <lmb@cloudflare.com>
Subject: Re: [PATCH bpf-next] docs/bpf: add llvm_reloc.rst to explain llvm bpf relocations
Date: Sat, 22 May 2021 09:44:25 -0700	[thread overview]
Message-ID: <aae741ff-d609-5796-d860-d234884f5ea2@fb.com> (raw)
In-Reply-To: <20210522163925.3757287-1-yhs@fb.com>



On 5/22/21 9:39 AM, Yonghong Song wrote:
> LLVM upstream commit https://reviews.llvm.org/D102712
> made some changes to bpf relocations to make them
> llvm linker lld friendly. The scope of
> existing relocations R_BPF_64_{64,32} is narrowed
> and new relocations R_BPF_64_{ABS32,ABS64,NODYLD32}
> are introduced.

Daniel, John and Lorenz,

Could you help check how the new relocation scheme
may impact you? libbpf has a similar issue and is fixed by
   https://lore.kernel.org/bpf/20210522162341.3687617-1-yhs@fb.com/
In most cases, you should just change relocation enum number,
no relocation resolution is changed.

Please let me know. Thanks!

> 
> Let us add some documentation about llvm bpf
> relocations so people can understand how to resolve
> them properly in their respective tools.
> 
> Cc: John Fastabend <john.fastabend@gmail.com>
> Cc: Lorenz Bauer <lmb@cloudflare.com>
> Signed-off-by: Yonghong Song <yhs@fb.com>
> ---
>   Documentation/bpf/index.rst      |   1 +
>   Documentation/bpf/llvm_reloc.rst | 168 +++++++++++++++++++++++++++++++
>   2 files changed, 169 insertions(+)
>   create mode 100644 Documentation/bpf/llvm_reloc.rst
> 
[..]

  reply	other threads:[~2021-05-22 16:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-22 16:39 [PATCH bpf-next] docs/bpf: add llvm_reloc.rst to explain llvm bpf relocations Yonghong Song
2021-05-22 16:44 ` Yonghong Song [this message]
2021-05-24  8:33   ` Lorenz Bauer
2021-05-24 15:06     ` Yonghong Song
2021-05-24 17:23 ` Andrii Nakryiko
2021-05-24 18:01   ` Yonghong Song
2021-05-24 19:20     ` Andrii Nakryiko
2021-05-24 19:24     ` John Fastabend
2021-05-25  3:39       ` Yonghong Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aae741ff-d609-5796-d860-d234884f5ea2@fb.com \
    --to=yhs@fb.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=john.fastabend@gmail.com \
    --cc=kernel-team@fb.com \
    --cc=lmb@cloudflare.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox