[PATCH bpf] selftests/bpf: Fix pkg-config call on static builds

[PATCH bpf] selftests/bpf: Fix pkg-config call on static builds

[Paul Chaignon]

For commit b0dcdcb9ae75 ("resolve_btfids: Fix linker flags detection"),
I suggested setting HOSTPKG_CONFIG to $PKG_CONFIG when compiling
resolve_btfids, but I forgot the quotes around that variable.

As a result, when running vmtest.sh with static linking, it fails as
follows:

    $ LDLIBS=-static PKG_CONFIG='pkg-config --static' ./vmtest.sh
    [...]
    make: unrecognized option '--static'
    Usage: make [options] [target] ...
    [...]

This worked when I tested it because HOSTPKG_CONFIG didn't have a
default value in the resolve_btfids Makefile, but once it does, the
quotes aren't preserved and it fails on the next make call.

Fixes: b0dcdcb9ae75 ("resolve_btfids: Fix linker flags detection")
Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
---
 tools/testing/selftests/bpf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
index d5acbeba0383..65485967c968 100644
--- a/tools/testing/selftests/bpf/Makefile
+++ b/tools/testing/selftests/bpf/Makefile
@@ -409,7 +409,7 @@ $(RESOLVE_BTFIDS): $(HOST_BPFOBJ) | $(HOST_BUILD_DIR)/resolve_btfids	\
 		CC="$(HOSTCC)" LD="$(HOSTLD)" AR="$(HOSTAR)" \
 		LIBBPF_INCLUDE=$(HOST_INCLUDE_DIR) \
 		EXTRA_LDFLAGS='$(SAN_LDFLAGS) $(EXTRA_LDFLAGS)' \
-		HOSTPKG_CONFIG=$(PKG_CONFIG) \
+		HOSTPKG_CONFIG='$(PKG_CONFIG)' \
 		OUTPUT=$(HOST_BUILD_DIR)/resolve_btfids/ BPFOBJ=$(HOST_BPFOBJ)
 
 # Get Clang's default includes on this system, as opposed to those seen by
-- 
2.43.0

Re: [PATCH bpf] selftests/bpf: Fix pkg-config call on static builds

[Mykyta Yatsenko]

Paul Chaignon <paul.chaignon@gmail.com> writes:

> For commit b0dcdcb9ae75 ("resolve_btfids: Fix linker flags detection"),
> I suggested setting HOSTPKG_CONFIG to $PKG_CONFIG when compiling
> resolve_btfids, but I forgot the quotes around that variable.
>
> As a result, when running vmtest.sh with static linking, it fails as
> follows:
>
>     $ LDLIBS=-static PKG_CONFIG='pkg-config --static' ./vmtest.sh
>     [...]
>     make: unrecognized option '--static'
>     Usage: make [options] [target] ...
>     [...]
>
> This worked when I tested it because HOSTPKG_CONFIG didn't have a
> default value in the resolve_btfids Makefile, but once it does, the
> quotes aren't preserved and it fails on the next make call.
>
> Fixes: b0dcdcb9ae75 ("resolve_btfids: Fix linker flags detection")
> Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
> ---
Acked-by: Mykyta Yatsenko <yatsenko@meta.com>
>  tools/testing/selftests/bpf/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index d5acbeba0383..65485967c968 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
> @@ -409,7 +409,7 @@ $(RESOLVE_BTFIDS): $(HOST_BPFOBJ) | $(HOST_BUILD_DIR)/resolve_btfids	\
>  		CC="$(HOSTCC)" LD="$(HOSTLD)" AR="$(HOSTAR)" \
>  		LIBBPF_INCLUDE=$(HOST_INCLUDE_DIR) \
>  		EXTRA_LDFLAGS='$(SAN_LDFLAGS) $(EXTRA_LDFLAGS)' \
> -		HOSTPKG_CONFIG=$(PKG_CONFIG) \
> +		HOSTPKG_CONFIG='$(PKG_CONFIG)' \
>  		OUTPUT=$(HOST_BUILD_DIR)/resolve_btfids/ BPFOBJ=$(HOST_BPFOBJ)
>  
>  # Get Clang's default includes on this system, as opposed to those seen by
> -- 
> 2.43.0

Re: [PATCH bpf] selftests/bpf: Fix pkg-config call on static builds

[Ihor Solodrai]

On 3/10/26 4:39 AM, Paul Chaignon wrote:
> For commit b0dcdcb9ae75 ("resolve_btfids: Fix linker flags detection"),
> I suggested setting HOSTPKG_CONFIG to $PKG_CONFIG when compiling
> resolve_btfids, but I forgot the quotes around that variable.
> 
> As a result, when running vmtest.sh with static linking, it fails as
> follows:
> 
>     $ LDLIBS=-static PKG_CONFIG='pkg-config --static' ./vmtest.sh
>     [...]
>     make: unrecognized option '--static'
>     Usage: make [options] [target] ...
>     [...]
> 
> This worked when I tested it because HOSTPKG_CONFIG didn't have a
> default value in the resolve_btfids Makefile, but once it does, the
> quotes aren't preserved and it fails on the next make call.
> 
> Fixes: b0dcdcb9ae75 ("resolve_btfids: Fix linker flags detection")
> Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
> ---
>  tools/testing/selftests/bpf/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index d5acbeba0383..65485967c968 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
> @@ -409,7 +409,7 @@ $(RESOLVE_BTFIDS): $(HOST_BPFOBJ) | $(HOST_BUILD_DIR)/resolve_btfids	\
>  		CC="$(HOSTCC)" LD="$(HOSTLD)" AR="$(HOSTAR)" \
>  		LIBBPF_INCLUDE=$(HOST_INCLUDE_DIR) \
>  		EXTRA_LDFLAGS='$(SAN_LDFLAGS) $(EXTRA_LDFLAGS)' \
> -		HOSTPKG_CONFIG=$(PKG_CONFIG) \
> +		HOSTPKG_CONFIG='$(PKG_CONFIG)' \

That's an oopsie... Thanks for fixing.

Acked-by: Ihor Solodrai <ihor.solodrai@linux.dev>

>  		OUTPUT=$(HOST_BUILD_DIR)/resolve_btfids/ BPFOBJ=$(HOST_BPFOBJ)
>  
>  # Get Clang's default includes on this system, as opposed to those seen by

Re: [PATCH bpf] selftests/bpf: Fix pkg-config call on static builds

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Tue, 10 Mar 2026 12:39:51 +0100 you wrote:
> For commit b0dcdcb9ae75 ("resolve_btfids: Fix linker flags detection"),
> I suggested setting HOSTPKG_CONFIG to $PKG_CONFIG when compiling
> resolve_btfids, but I forgot the quotes around that variable.
> 
> As a result, when running vmtest.sh with static linking, it fails as
> follows:
> 
> [...]

Here is the summary with links:
  - [bpf] selftests/bpf: Fix pkg-config call on static builds
    https://git.kernel.org/bpf/bpf/c/e06e6b800123

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html