From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F9C931F9A2 for ; Thu, 12 Mar 2026 12:38:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773319093; cv=none; b=KhpbWChQy+6001HvWSsrW0sFm+VeZtxZx3XSmUEfPcMEUYysQa1VZKs7m0o2ACs/KrZXmXwMmy+QkKunu9JY70puo5gjCdtSUI77VxbqbRsgWELXcj3myxK3E2PaNbP1Bdd9mU0i0S2vLrqFRufpgeT/5Sks6mpU2JtHJffSfBI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773319093; c=relaxed/simple; bh=nIfDf+pZH4rz6UU/6W6FX3WRSUuva6kGMVYjbvPfW7Y=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H1/3UbFnkVr5FMXw/cBTwf5ms8+JLJjbzKebf/8onf/hkRTiHQxiDSi3tB+0NRi3jpsV3SYg8bbScPH0/0WAIOr/aoGCjsFvter06xxTaH0mQA8EaQvz3dZQ46Uu0zpe6cce4ZA67mpkFZdSl3RPgSuEvNO2a1sLiBn8n04WRfk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V62HzhPh; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V62HzhPh" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-48541edecf9so10134315e9.1 for ; Thu, 12 Mar 2026 05:38:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773319086; x=1773923886; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=Ds8XmIw4rytuzFN00yBWaHDuFdQzJihgPn8GrBJUq+4=; b=V62HzhPheVs1Xr15YReTWJfcwWDBTcBxK0+jIw9meBjwne72tj+HMWQNLcT6N9v7tm LRmRXJXpC+XBkp+2pcKdumejKBK4dIEaDJg3UnK8kNC2FgDNMSQ6rQ0gL4fW0oARv6Fw seAj4KCLtO333IjucFsdlT1qTHLG859miOJ7KadvL98595nTlTLOxFEdsLnEhzKPvcfJ dgeoMJYTSfwivwRQcx8apijznnvQ8LhzFVzyMmAkXfAVYDhaugTBxt8mbuSh9Eu87DAP xHXXGPagDEJBnZdtbv9Ab2WTnPWiqNnmhVSl8QJnuJkzMawgTzW9WLUURciqtMlZLotb wl8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773319086; x=1773923886; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ds8XmIw4rytuzFN00yBWaHDuFdQzJihgPn8GrBJUq+4=; b=L40SCvi7PTVssf2O8OuNLMAcHb07qCT32wrpsjlFRk4+d+6qP2QOGwkPsm3E9jJ0cy tp8e1TidS66j3ZpBV0X//k/YtUkW5HtgPGsXKjS4klOKJhNsZfw47NYEPJaQNYzQ1UrK HKSukItXQnmfpFzr1MSVq1bxS9jtQAD59ePL4yxOXHMqfRw+73aGQt1OxNiMgeZCfEY/ ZY/d3RRI29ZvOf/8V1ZPbJqTqC0eRMtUM+OMvYxe08XiFQbFH9BYZ3ubNqgdPsrEcOdK lPjiSfYHVMi6HcbhG0mA6O1dyGoKOKsh5y97sKidl5PtRMFjKPNHi93XOtteps2YuHN2 iC4Q== X-Forwarded-Encrypted: i=1; AJvYcCV2Gs4ANiEWf5ElfBOl9eyAYqVV6FfjhhdNHNEPVHohDwxshs09LHAn/eMiDYHl6VomXMI=@vger.kernel.org X-Gm-Message-State: AOJu0YzNBpkJzgEzRjSZzNTAiucdadoHnGXUm+D/LJ+LNnAIYXz8HPWm SdLk10ogPldhBbND6Ft6DzC3UarZHBOkG+dvw2iFY+A38pML8ndD42Iw X-Gm-Gg: ATEYQzzqo/1p5iytOUTMMaay1Xixc0tPhBo507d7jRGtwI/wA1oukJzZbvqB8P9JdwJ 0OV85GKfV1mkMbIyQmkJfjdYvKW1li0d6XxE8xEUKhqM5qOqBKGWHVkLwqDaizFMKCgfp7IoIOP DfJN6h7RB9JhhxbCRPVlfDPQo/BqQAPPay+JX2li3RdifTielvBxrJ6DkJqYzBlHZvcdv0FvYIq +0xZBl2hjecJo5MtjNlvsk6Ey11EYHteS3hEqmRHh8NAX4EY7TZ2eLADvz+sVwbiwBD3uKSNRxG GTgC/ISXKPhWMjd3K8RY1SO66zSt4wJfF7VPWyHfIW0r2vXtLmRLJ7mi9uaYv+nGHbCPgRdTIcN gNWDdhYcQCmCgp3qVOaD8qrb7ZL2mmjOhDV3oHgs1dLXiKnfL+DF19ekIDQXG+VXeSYjj22HZ X-Received: by 2002:a05:600c:a08:b0:485:2c61:9459 with SMTP id 5b1f17b1804b1-4854b0afb48mr108156565e9.8.1773319086489; Thu, 12 Mar 2026 05:38:06 -0700 (PDT) Received: from krava ([2a02:8308:a00c:e200::d99c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854b5f6bb4sm126330325e9.4.2026.03.12.05.38.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 05:38:06 -0700 (PDT) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Thu, 12 Mar 2026 13:38:04 +0100 To: bot+bpf-ci@kernel.org Cc: rostedt@kernel.org, ast@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, daniel@iogearbox.net, andrii@kernel.org, menglong8.dong@gmail.com, song@kernel.org, martin.lau@kernel.org, eddyz87@gmail.com, yonghong.song@linux.dev, clm@meta.com, ihor.solodrai@linux.dev Subject: Re: [PATCH bpf-next] ftrace: Use hash argument for tmp_ops in update_ftrace_direct_mod Message-ID: References: <20260312114746.122174-1-jolsa@kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Mar 12, 2026 at 12:24:24PM +0000, bot+bpf-ci@kernel.org wrote: > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > > index 8df69e702706..71dcbfeac86c 100644 > > --- a/kernel/trace/ftrace.c > > +++ b/kernel/trace/ftrace.c > > @@ -6608,7 +6608,7 @@ int update_ftrace_direct_mod(struct ftrace_ops *ops, struct ftrace_hash *hash, b > > > > /* Enable the tmp_ops to have the same functions as the direct ops */ > > ftrace_ops_init(&tmp_ops); > > - tmp_ops.func_hash = ops->func_hash; > > + tmp_ops.func_hash->filter_hash = hash; > > The comment above says "Enable the tmp_ops to have the same functions > as the direct ops", but after this change tmp_ops only gets the > modified subset via the hash argument, not all of the direct ops > functions. Should the comment be updated to reflect this? > > Also, the commit message has a minor grammar issue: > > > which contains only the modified sites is always a subset of the > > ops->func_hash. > > Reads like it is missing an "and" between "sites" and "is". yep, sent v2 jirka